From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2] ASoC: wm9713: convert to regmap
Date: Mon, 26 Oct 2015 19:02:32 +0100 [thread overview]
Message-ID: <87y4epjyo7.fsf@belgarion.home> (raw)
In-Reply-To: <562E0E18.80500@metafoo.de> (Lars-Peter Clausen's message of "Mon, 26 Oct 2015 12:27:20 +0100")
Lars-Peter Clausen <lars@metafoo.de> writes:
> On 10/24/2015 11:37 PM, Robert Jarzmik wrote:
> [...]
>> -static unsigned int ac97_read(struct snd_soc_codec *codec,
>> - unsigned int reg);
>> -static int ac97_write(struct snd_soc_codec *codec,
>> - unsigned int reg, unsigned int val);
>
> For review purposes it would be helpful to split this into two patches. One
> performing the regmap conversion the other replacing
> ac97_read()/ac97_write() with the matching snd_soc_ calls (or
> snd_soc_update_bits).
Most certainly, I'll do that. If bissection is not broken, it's fine by me.
>> + snd_soc_codec_init_regmap(codec, regmap);
>
> You need to call snd_soc_odec_exit_regmap() when the CODEC is unbound.
Ah yes, I'll put that in the next iteration, thanks.
Cheers.
--
Robert
prev parent reply other threads:[~2015-10-26 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 21:37 Robert Jarzmik
2015-10-26 11:02 ` Charles Keepax
2015-10-26 17:53 ` Robert Jarzmik
2015-10-27 9:10 ` Charles Keepax
2015-10-26 11:27 ` [alsa-devel] " Lars-Peter Clausen
2015-10-26 18:02 ` Robert Jarzmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4epjyo7.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®