From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756583AbbIULZo (ORCPT ); Mon, 21 Sep 2015 07:25:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52219 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbbIULZm (ORCPT ); Mon, 21 Sep 2015 07:25:42 -0400 From: Vitaly Kuznetsov To: Olaf Hering Cc: "K. Y. Srinivasan" , Greg KH , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, jasowang@redhat.com Subject: Re: [PATCH 2/5] hv: add helpers to handle hv_util device state References: <1442363823-22428-1-git-send-email-kys@microsoft.com> <1442363874-22508-1-git-send-email-kys@microsoft.com> <1442363874-22508-2-git-send-email-kys@microsoft.com> <20150921052532.GA24350@kroah.com> <20150921102626.GB4252@aepfle.de> Date: Mon, 21 Sep 2015 13:25:38 +0200 In-Reply-To: <20150921102626.GB4252@aepfle.de> (Olaf Hering's message of "Mon, 21 Sep 2015 12:26:26 +0200") Message-ID: <87y4g0hv4d.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Olaf Hering writes: > On Sun, Sep 20, Greg KH wrote: > >> Just use a lock, that's what it is there for. > > How would that help? It might help because it enforces ordering. But > that requires that all three utils get refactored to deal with the > introduced locking. I will let KY comment on this. > > The issue I see with fcopy is that after or while fcopy_respond_to_host > runs an interrupt triggers which also calls into > hv_fcopy_onchannelcallback. It was most likely caused by a logic change > in "recent" vmbus updates because this did not happen before. At least, > the fcopy hang was not seen earler. Maybe the bug did just not trigger > up to now for other reasons... I'd like to see a trace from the hang, it is not obvious to me how it happened and what caused it. (or if you have such hang scenario in your head, can you please reveal it?) AFAICS barriers you introduced don't give you guarantees in an SMP environment. -- Vitaly