From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Jiri Kosina <trivial@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Mack <zonque@gmail.com>,
Robert Jarzmik <robert.jarzmik@intel.com>
Subject: Re: [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions
Date: Sat, 20 Jun 2015 23:48:15 +0200 [thread overview]
Message-ID: <87y4je831c.fsf@belgarion.home> (raw)
In-Reply-To: <Pine.LNX.4.64.1506201503550.31977@axis700.grange> (Guennadi Liakhovetski's message of "Sat, 20 Jun 2015 15:29:00 +0200 (CEST)")
Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:
>> +static void pxa_camera_dma_irq(struct pxa_camera_dev *pcdev,
>> + enum pxa_camera_active_dma act_dma);
>> +
>> +static void pxa_camera_dma_irq_y(void *data)
>
> Wait, how is this patch trivial? You change pxa_camera_dma_irq_?()
> prototypes, which are used as PXA DMA callbacks. Does this mean, that
> either before or after this patch compilation is broken?
Jeez you're right.
So I can either fold that with patch 4, or try to rework it somehow ...
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2015-06-20 21:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 23:21 [PATCH 0/4] media: pxa_camera conversion to dmaengine Robert Jarzmik
2015-03-21 23:21 ` [PATCH 1/4] media: pxa_camera: fix the buffer free path Robert Jarzmik
2015-03-21 23:21 ` [PATCH 2/4] media: pxa_camera: move interrupt to tasklet Robert Jarzmik
2015-03-21 23:21 ` [PATCH 3/4] media: pxa_camera: trivial move of dma irq functions Robert Jarzmik
2015-06-20 13:29 ` Guennadi Liakhovetski
2015-06-20 21:48 ` Robert Jarzmik [this message]
2015-06-21 16:11 ` Guennadi Liakhovetski
2015-06-21 18:05 ` Robert Jarzmik
2015-03-21 23:21 ` [PATCH 4/4] media: pxa_camera: conversion to dmaengine Robert Jarzmik
2015-06-04 11:20 ` Guennadi Liakhovetski
2015-06-07 19:17 ` Robert Jarzmik
2015-06-21 16:02 ` Guennadi Liakhovetski
2015-06-21 17:16 ` Robert Jarzmik
2015-05-27 19:12 ` [PATCH 0/4] media: pxa_camera " Robert Jarzmik
2015-06-06 21:27 ` Robert Jarzmik
2015-06-07 13:25 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4je831c.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=robert.jarzmik@intel.com \
--cc=trivial@kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®