From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbbCSIVq (ORCPT ); Thu, 19 Mar 2015 04:21:46 -0400 Received: from canardo.mork.no ([148.122.252.1]:34169 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750891AbbCSIVm convert rfc822-to-8bit (ORCPT ); Thu, 19 Mar 2015 04:21:42 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Ondrej Zary Cc: netdev@vger.kernel.org, Kernel development list Subject: Re: [PATCH] Revert "net: cx82310_eth: use common match macro" Organization: m References: <1426716061-20953-1-git-send-email-linux@rainbow-software.org> Date: Thu, 19 Mar 2015 09:21:30 +0100 In-Reply-To: <1426716061-20953-1-git-send-email-linux@rainbow-software.org> (Ondrej Zary's message of "Wed, 18 Mar 2015 23:01:01 +0100") Message-ID: <87y4mtcs8l.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.3.9 (canardo.mork.no [IPv6:2001:4641::1]); Thu, 19 Mar 2015 09:21:37 +0100 (CET) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ondrej Zary writes: > This reverts commit 11ad714b98f6d9ca0067568442afe3e70eb94845 because > it breaks cx82310_eth. > > The custom USB_DEVICE_CLASS macro matches > bDeviceClass, bDeviceSubClass and bDeviceProtocol > but the common USB_DEVICE_AND_INTERFACE_INFO matches > bInterfaceClass, bInterfaceSubClass and bInterfaceProtocol instead, which are > not specified. Ouch. What ever made me do that? Thanks a lot for fixing it! This bug was introduced as long ago as v3.7, so the fix should go into every currently maintained stable branch since that. Bjørn