From: Rusty Russell <rusty@rustcorp.com.au>
To: "Theodore Ts'o" <tytso@mit.edu>, Joe Perches <joe@perches.com>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtio-dev@lists.oasis-open.org,
virtualization@lists.linux-foundation.org, fes@google.com
Subject: Re: [PATCH] virtio-blk: make the queue depth configurable
Date: Mon, 17 Mar 2014 14:25:52 +1030 [thread overview]
Message-ID: <87y509scl3.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140314180258.GA29201@thunk.org>
Theodore Ts'o <tytso@mit.edu> writes:
> On Fri, Mar 14, 2014 at 10:38:40AM -0700, Joe Perches wrote:
>> > +static int queue_depth = 64;
>> > +module_param(queue_depth, int, 444);
>>
>> 444? Really Ted?
>
> Oops, *blush*. Thanks for catching that.
Erk, our tests are insufficient. Testbuilding an allmodconfig with this
now:
diff --git a/include/linux/moduleparam.h b/include/linux/moduleparam.h
index 175f6995d1af..626b85888a6b 100644
--- a/include/linux/moduleparam.h
+++ b/include/linux/moduleparam.h
@@ -188,6 +188,9 @@ struct kparam_array
/* Default value instead of permissions? */ \
static int __param_perm_check_##name __attribute__((unused)) = \
BUILD_BUG_ON_ZERO((perm) < 0 || (perm) > 0777 || ((perm) & 2)) \
+ /* User perms >= group perms >= other perms. */ \
+ + BUILD_BUG_ON_ZERO(((perm) >> 6) < (((perm) >> 3) & 7)) \
+ + BUILD_BUG_ON_ZERO((((perm) >> 3) & 7) < ((perm) & 7)) \
+ BUILD_BUG_ON_ZERO(sizeof(""prefix) > MAX_PARAM_PREFIX_LEN); \
static const char __param_str_##name[] = prefix #name; \
static struct kernel_param __moduleparam_const __param_##name \
next prev parent reply other threads:[~2014-03-17 4:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-14 17:31 Theodore Ts'o
2014-03-14 17:38 ` Joe Perches
2014-03-14 18:02 ` Theodore Ts'o
2014-03-17 3:55 ` Rusty Russell [this message]
2014-03-17 5:00 ` Joe Perches
2014-03-17 7:26 ` Joe Perches
2014-03-19 6:37 ` Rusty Russell
2014-03-19 6:50 ` Joe Perches
2014-03-20 3:13 ` Stricter module param and sysfs permission checks Rusty Russell
2014-03-20 4:27 ` Dave Jones
2014-03-20 9:15 ` Alexey Dobriyan
2014-03-20 16:28 ` Robert Jarzmik
2014-06-18 15:07 ` Gobinda Charan Maji
2014-06-26 2:54 ` Gobinda Charan Maji
2014-07-03 5:52 ` Gobinda Charan Maji
2015-04-28 14:02 ` Gobinda Charan Maji
2014-03-19 16:07 ` [PATCH] virtio-blk: make the queue depth configurable Greg Kroah-Hartman
2014-03-19 16:57 ` Bjorn Helgaas
2014-03-19 17:31 ` Joe Perches
2014-03-20 3:35 ` Rusty Russell
2014-03-20 2:50 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y509scl3.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=fes@google.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=tytso@mit.edu \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome