mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	Morimoto <kuninori.morimoto.gx@renesas.com>,
	Linux-SH <linux-sh@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v2][RESENT] dma: add R-Car Audio DMAC peri peri driver
Date: Sun, 09 Mar 2014 19:19:51 -0700 (PDT)	[thread overview]
Message-ID: <87y50ire0r.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <1394416022.30791.7.camel@joe-AO722>


Hi Joe

> > diff --git a/drivers/dma/sh/rcar-audmapp.c b/drivers/dma/sh/rcar-audmapp.c
> []
> > +static int audmapp_chan_probe(struct platform_device *pdev,
> > +			      struct audmapp_device *audev, int id)
> > +{
> []
> > +	auchan = devm_kzalloc(dev, sizeof(struct audmapp_chan), GFP_KERNEL);
> > +	if (!auchan) {
> > +		dev_err(dev, "No free memory for allocating dma channels!\n");
> 
> Unnecessary OOM as the alloc has a generic OOM
> and a dump_stack()
> 
> []
> > +static int audmapp_probe(struct platform_device *pdev)
> > +{
> []
> > +	audev = devm_kzalloc(&pdev->dev, sizeof(struct audmapp_device),
> > +			     GFP_KERNEL);
> > +	if (!audev) {
> > +		dev_err(&pdev->dev, "Not enough memory\n");
> 
> here too

Thank you.
will fix in v3

  reply	other threads:[~2014-03-10  2:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-24  2:32 [PATCH] shdma: " Kuninori Morimoto
2014-01-24  7:34 ` Geert Uytterhoeven
2014-01-24  8:18   ` Kuninori Morimoto
2014-01-24  8:33     ` Geert Uytterhoeven
2014-01-24  8:58       ` Kuninori Morimoto
2014-01-24  9:06 ` [PATCH v2] dma: " Kuninori Morimoto
2014-02-12  5:29   ` Kuninori Morimoto
2014-02-25  5:13     ` Kuninori Morimoto
2014-03-10  1:34 ` [PATCH v2][RESENT] " Kuninori Morimoto
2014-03-10  1:47   ` Joe Perches
2014-03-10  2:19     ` Kuninori Morimoto [this message]
2014-03-10  9:13   ` Shevchenko, Andriy
2014-03-10  2:25 ` [PATCH v3] shdma: " Kuninori Morimoto
2014-03-10  9:15   ` Shevchenko, Andriy
2014-03-11  1:11 ` Kuninori Morimoto
2014-03-25  1:08   ` Kuninori Morimoto
2014-03-29 14:08   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y50ire0r.wl%kuninori.morimoto.gx@gmail.com \
    --to=kuninori.morimoto.gx@gmail.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=joe@perches.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®