mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@sunsite.dk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Hebbar\, Gururaja" <gururaja.hebbar@ti.com>,
	alsa-devel@alsa-project.org, sudhakar.raj@ti.com,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org, nsekhar@ti.com,
	davinci-linux-open-source@linux.davincidsp.com, perex@perex.cz,
	lrg@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support
Date: Mon, 26 Nov 2012 21:55:33 -0800	[thread overview]
Message-ID: <87y5hn1tey.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20121126114511.GE9411@opensource.wolfsonmicro.com> (Mark Brown's message of "Mon, 26 Nov 2012 11:45:11 +0000")

>>>>> "Mark" == Mark Brown <broonie@opensource.wolfsonmicro.com> writes:

Hi,

 Mark> On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:
 >> +	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
 >> +	if (IS_ERR(pinctrl))
 >> +		dev_warn(&pdev->dev,
 >> +			"pins are not configured from the driver\n");

 Mark> Since the driver is happy to continue without the pins why is it
 Mark> bothering requesting them in the first place?  In other words, this
 Mark> should be a hard error.

Sorry, I disagree. As was discussed recently, there's several reasons
why the pinctrl call might fail, and not all are fatal (E.G. pinmux
already setup by bootloader):

http://article.gmane.org/gmane.linux.kernel/1399756

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-11-27  5:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  4:04 [PATCH 0/2] ARM/ASoC: Davinci: Device Tree Update Hebbar, Gururaja
2012-11-22  4:04 ` [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support Hebbar, Gururaja
2012-11-26 11:45   ` Mark Brown
2012-11-27  5:55     ` Peter Korsgaard [this message]
2012-11-27 14:04       ` Mark Brown
2012-11-22  4:04 ` [PATCH 2/2] ASoC: Davinci: machine: Add device tree binding Hebbar, Gururaja
2012-11-26 11:56   ` Mark Brown
2012-11-27 12:53     ` Hebbar, Gururaja
2012-11-26 11:41 ` [PATCH 0/2] ARM/ASoC: Davinci: Device Tree Update Hebbar, Gururaja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5hn1tey.fsf@dell.be.48ers.dk \
    --to=jacmet@sunsite.dk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=gururaja.hebbar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=nsekhar@ti.com \
    --cc=perex@perex.cz \
    --cc=sudhakar.raj@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®