mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Kyungmin Park <kmpark@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH v5] fat: Batched discard support for fat
Date: Mon, 28 Mar 2011 16:33:25 +0900	[thread overview]
Message-ID: <87y63z4s3e.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <AANLkTinTzj_BurexWAHa+EOt+GvpMB3Xm=GdtwdAt8i2@mail.gmail.com> (Kyungmin Park's message of "Mon, 28 Mar 2011 15:56:42 +0900")

Kyungmin Park <kmpark@infradead.org> writes:

>> Yes. It's what I'm saying. If user wants to trim 0-2 then user will
>> specify 0-2, but this trims only 2. It's not right.
>
> There's similar code at ext4. it adjusts the start and len value if
> given start is less than first_data_blk.
>
>        if (start < first_data_blk) {
>                 len -= first_data_blk - start;
>                 start = first_data_blk;
>         }

Oh, strange design. On this design, user have to know which block is
actually start block per FSes (Yeah, you can still use this without
start block knowledge. But it's bogus). I think it should fix ext4. No?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

      reply	other threads:[~2011-03-28  7:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  2:04 Kyungmin Park
2011-03-27 15:39 ` OGAWA Hirofumi
2011-03-28  5:57   ` Kyungmin Park
2011-03-28  6:21     ` OGAWA Hirofumi
2011-03-28  6:56       ` Kyungmin Park
2011-03-28  7:33         ` OGAWA Hirofumi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y63z4s3e.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=kmpark@infradead.org \
    --cc=lczerner@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®