mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Frodo Looijaard <frodol@dds.nl>
Cc: "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org
Subject: Re: PATCH to access old-style FAT fs
Date: Thu, 29 Jan 2004 05:08:32 +0900	[thread overview]
Message-ID: <87y8rr7s5b.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20040128115655.GA696@arda.frodo.local>

Frodo Looijaard <frodol@dds.nl> writes:

> As I said, I *think* it is safe to have my patch always applied (that
> is, stop when DIR_Name[0] == 0, and be careful to add a new DIR_Name[0] = 0
> entry when new entries are added at the back). It would conform to the
> standard.  But I would not really be surprised if there was yet another
> FAT implementation somewhere out there that breaks the standard in some
> other subtle way, which works now but exhibits problems with my patch.
> That is why I made it a mount option.

"stop when DIR_Name[0] == 0" should be added after cleanup. The option
is not needed.

Honestly, I wouldn't like to add the "add a new DIR_Name[0] = 0" part.
The option is added easy, but it is not removed easy. And we must
maintain it.  (BTW, looks like that patch is buggy)

Those stuff makes a change of the normal path difficult really. At the
same reason, I removed the fat_cvf stuff.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

  reply	other threads:[~2004-01-28 20:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-26 17:39 Frodo Looijaard
2004-01-26 19:38 ` H. Peter Anvin
2004-01-27 12:55   ` OGAWA Hirofumi
2004-01-27 18:51     ` H. Peter Anvin
2004-01-27 20:17       ` OGAWA Hirofumi
2004-01-28 11:56         ` Frodo Looijaard
2004-01-28 20:08           ` OGAWA Hirofumi [this message]
2004-01-28 20:24             ` Frodo Looijaard
2004-01-28 21:01               ` OGAWA Hirofumi
2004-01-29 10:56                 ` Frodo Looijaard
2004-01-31  2:19                   ` H. Peter Anvin
2004-01-31 17:19                     ` OGAWA Hirofumi
2004-01-29 22:39                 ` Frodo Looijaard
2004-01-29 22:49                   ` H. Peter Anvin
2004-01-30  0:30                   ` Andries Brouwer
2004-01-30  3:40                   ` OGAWA Hirofumi
2004-02-01 14:51                   ` Frodo Looijaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y8rr7s5b.fsf@devron.myhome.or.jp \
    --to=hirofumi@mail.parknet.co.jp \
    --cc=frodol@dds.nl \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome