Re: [PATCH v7 0/8] ALSA: usb: add RME Babyface Pro driver (proprietary mode)

[Takashi Iwai <tiwai@suse.de>]

On Tue, 27 Oct 2026 12:31:31 +0100,
Ismaïl Bahloul wrote:
> 
> Hi Takashi,
> 
> This is v7 of the RME Babyface Pro proprietary-mode driver.  The split
> is the one you asked for in the v4 review and that v5 introduced: a
> minimal core first, the mixer added piece by piece, suspend/resume near
> the end, the front panel and the DSP EQ last, and a design document.
> v7 keeps that split and folds in the fixes made since v6, and is
> rebased onto next-20261026, the most recent snapshot at the time of
> writing.
> 
> This is not an RFC.  The split you asked for in the v4 review has been
> in place since v5, the open points at the end are documented and none
> of them blocks a merge, so the series is submitted for merge rather
> than for another design round.

Thanks for the updates.  The split patches look much better than
before, which made easier to review.

I haven't fully reviewed in details, but I see you've received quite a
few complaints from Sashiko, so please check them again, and fix if
they are valid.  If they are to be ignored, just explain.

In general, a few things I noticed:

- Please try to use the new guard & co macros for spin/mutex locks and
  RCU.  They are much safer than manual lock/unlock.  (A caveat is
  that you need to be careful not to mix up with guard() and goto,
  though.)

- The inner loop of babyface_playback_copy() and *_capture_copy() can
  be simple memcpy().  You basically copy each 4 bytes as-is and they
  are continuous for channels, after all.

- The bf_seen_before() may lead to unlimited amount of list contents,
  which isn't really good.


thanks,

Takashi