From: Nam Cao <namcao@linutronix.de>
To: Omer PALA <palaomer100@gmail.com>,
vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org,
elder@kernel.org, gregkh@linuxfoundation.org
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: add newline to sysfs_emit return
Date: Wed, 16 Sep 2026 23:26:49 +0200 [thread overview]
Message-ID: <87zexgyjja.fsf@yellow.woof> (raw)
In-Reply-To: <20260916155855.9022-1-palaomer100@gmail.com>
Omer PALA <palaomer100@gmail.com> writes:
> Add a terminating newline character to sysfs_emit() format strings in
> audio_manager_module.c.
>
> Without a trailing newline, reading sysfs attributes directly from user
> space (e.g., using `cat`) appends the command prompt to the output string,
> leading to broken formatting. Including '\n' ensures compliance with
> sysfs single-value formatting standards and prevents parsing issues in
> user space tools and scripts.
>
> Signed-off-by: Omer PALA <palaomer100@gmail.com>
Also no, sorry. See:
https://lore.kernel.org/linux-staging/anw3nOfSGKoq-1E_@stanley.mountain/
It is a good idea to look up the mailing list archive for other patches
attempting to do the same thing.
Nam
next prev parent reply other threads:[~2026-09-16 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 15:58 Omer PALA
2026-09-16 21:26 ` Nam Cao [this message]
2026-09-17 4:59 ` Ömer PALA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zexgyjja.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=palaomer100@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®