mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Chen-Yu Tsai <wens@kernel.org>,
	 Jernej Skrabec <jernej.skrabec@gmail.com>,
	 Samuel Holland <samuel@sholland.org>,
	 Boris Brezillon <bbrezillon@kernel.org>,
	 linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: sunxi: fit maximized ECC step to page size
Date: Tue, 08 Sep 2026 12:03:33 +0200	[thread overview]
Message-ID: <87zexst5ze.fsf@bootlin.com> (raw)
In-Reply-To: <20260904-submit-sunxi-nand-ecc-step-validation-v2-1-6e3ba6200948@gmail.com> (James Hilliard's message of "Fri, 04 Sep 2026 16:39:27 -0600")

Hello James,

On 04/09/2026 at 16:39:27 -06, James Hilliard <james.hilliard1@gmail.com> wrote:

> When nand-ecc-maximize is set, the driver unconditionally selects a
> 1024-byte ECC step. A NAND with a 512-byte page consequently produces
> zero ECC steps before the available OOB bytes are divided by the step
> count.
>
> The older sunxi NAND controllers support 512-byte ECC blocks. Select the
> smaller of the page size and the preferred 1024-byte step, using a
> 512-byte step for a 512-byte page while retaining 1024-byte steps for
> larger pages. Unsupported smaller steps and controllers without
> 512-byte support continue to be rejected by the existing checks.
>
> Fixes: 4796d8655915 ("mtd: nand: sunxi: Support ECC maximization")
> Cc: stable@vger.kernel.org
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

As reported by Sashiko, there is another use of 1024 down the road which
must be modified accordingly. Although, in practice, 512-byte page NANDs
have disappeared for quite some time, so this is a theoretical fix more
than a real problem.

Thanks,
Miquèl

  reply	other threads:[~2026-09-08 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 22:39 James Hilliard
2026-09-08 10:03 ` Miquel Raynal [this message]
2026-09-08 15:27   ` James Hilliard
2026-09-08 15:55     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zexst5ze.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=bbrezillon@kernel.org \
    --cc=james.hilliard1@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=richard@nod.at \
    --cc=samuel@sholland.org \
    --cc=stable@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®