mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jakub Pisarczyk <pisarz77@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com, perex@perex.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/cs420x: Add CS4208 fixup for iMac16,1
Date: Wed, 27 May 2026 07:21:35 +0200	[thread overview]
Message-ID: <87zf1lwhpc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260526201830.34097-1-pisarz77@gmail.com>

On Tue, 26 May 2026 22:18:30 +0200,
Jakub Pisarczyk wrote:
> 
> The 21.5" Retina 4K iMac (Late 2015, DMI product name "iMac16,1") ships
> with a Cirrus Logic CS4208 codec wired to an external speaker amplifier
> enabled through codec GPIO0 -- the same arrangement as the late-2013
> MacBookPro 11,x. Without a matching entry in cs4208_mac_fixup_tbl[] the
> fixup picker logs:
> 
>     snd_hda_codec_cs420x hdaudioC1D0: CS4208: picked fixup  for codec SSID 106b:0000
> 
> i.e. an empty fixup name, GPIO0 stays low, the external amp is never
> powered up, and the internal speakers are silent on a stock kernel.
> 
> The codec SSID reported by hardware is 0x106b:0x7f00. Reusing CS4208_MBP11
> (GPIO0 + SPDIF switch fixup) makes the internal speakers and S/PDIF
> output work out of the box, removing the need for users to set
> `options snd_hda_intel model=mbp11` via /etc/modprobe.d/.
> 
> Tested on iMac16,1 (kernel 6.17.0): four internal drivers
> (Left tweeter, Left woofer, Right tweeter, Right woofer, exposed as the
> 4 channels of the analog-surround-40 ALSA profile) produce audio after
> the fixup is applied.
> 
> Signed-off-by: Jakub Pisarczyk <pisarz77@gmail.com>

Applied now.  Thanks.


Takashi

      reply	other threads:[~2026-05-27  5:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 20:18 Jakub Pisarczyk
2026-05-27  5:21 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf1lwhpc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=pisarz77@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®