From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5ADA3A7836 for ; Tue, 12 May 2026 09:24:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778577868; cv=none; b=ue/NilKnd8yliS3bO5obfIqWATmEvjLL5FoLrz7j2NPZEvdtRCtLNv4IUU+U7/J9rBcDeGlEwnm9dHpUSNi1w07LbpA0U+cFiAIvEUJULB3Dy1aJ13O9ZM0RTtHdwFSIImubXYb6CgEYEV77Vyh3+Nv0g+ghpgVrW3DfCLa1ixc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778577868; c=relaxed/simple; bh=nXrMsX1dyARj9Wo+73eAYTzALmHOov6nmomqmcLe9dc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=UbDITvjcDZF1w7TqWKyr5Fno7GTvAQzARuz+DH84Rgf3NglVqn1CCfzU35weufEFmSflTLeLnzDKX1IE7WCS+F3y+ngSC0mu2+wK4IBOA8khstB2aUv5F6oJvxKxwjOCCrcAqiayJ+gbDww/r/EOIpQYNGk9DL6yqnS8WTt81Zs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SBrL9pBw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IUlLT5CJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SBrL9pBw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IUlLT5CJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778577866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=M2jTkG6krSvGgEmmvUb0pId6kP5wDNo5oVW+s4FpOVw=; b=SBrL9pBw7u2JT56HIMvoRPfNt1goQ/sbgSRo7fdvaOY/s0ESzCu8coukzveuNHv0P7fcdM Otq7VpWORKuzb7koDiJxBUnsymbsWTEzTUkorRj+pZB4kvn3VZm+dP8XHnhLnY5yHSTHXN EpNhbwj3pusrE4qx1gzEX4aPgv4KtZk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-YbxceIIAOlOOFG_mFY53cQ-1; Tue, 12 May 2026 05:24:24 -0400 X-MC-Unique: YbxceIIAOlOOFG_mFY53cQ-1 X-Mimecast-MFC-AGG-ID: YbxceIIAOlOOFG_mFY53cQ_1778577864 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48d1b294dfeso47870875e9.0 for ; Tue, 12 May 2026 02:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778577863; x=1779182663; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=M2jTkG6krSvGgEmmvUb0pId6kP5wDNo5oVW+s4FpOVw=; b=IUlLT5CJn9nhcGq7sR4VxNXz7h0c2O5uHCM/yufX55RWJeQuoNmfW+LIMqHistrumk 19JeVyFo59m4uxfh/21G0wcI2BODyXf7U+YPUcfpAzdOwi0nfOSSFwECCUBebeXv/Lfa EV5biXSBXhf97l1STG5ydHF2pJp4iQYh+34TDkDJZ1STfN/PogXGo/lVyNyFS8dPzwhJ upjepjxXLJEobJ/iI6dyBi1yv/0jAx1Vmv2jbX0Dh2ZBF1AWeSJVEbTHKCFWeFe1bTOQ KOtWqgWW/xqSUpShMI7FQMtxT85Em/HK1qdC/2kZ/t0FVQo6RF/FaPGp5uj1ruL9egdg oAZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778577863; x=1779182663; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M2jTkG6krSvGgEmmvUb0pId6kP5wDNo5oVW+s4FpOVw=; b=gXN6Ig3Ga+yD9mQAQpSupoW7ZGuKDBmt2cHhx1JdXJra+GE13yQeve66ZpZhhYbDdh 466aUdsSE5w5y+3kv4MQSN8BFv7yuXuMyULXmTsM1YSi0tB38KbjCYJIAYjMp8hFWf21 +BDs6AiH3BlYpG+OO2RA0yUbw9E9Kdi/J805BZgEMrBSeGfl7bhDoWoSIHzdo/uSRlac ZsTvtPnBNDZDXUf6/Z6f11lX6G3T+sDQfbiETNoQlWmQpaGkOXsvolE5nHZWS05+JWPA bCe/uyCNCK1ttKJrcWluf/9tFkrkkFQhBlmvMAGEA7RBwzUo45llylpOqNKCIIUI80nV 8V2g== X-Gm-Message-State: AOJu0Yxi4mU5Ww9m7Fv09+857Ex9UIXJIf0cm54ZzlbAIATECvm4Vu+v pMaV5moKg+4ayfoigFEeRsRZlB9U7fQwd+ioM9QYb7MzVVcG93sT9a8BtsUfVUdJR8La7f1fC+T vkv4iSI56Ak7MSjJs4E2qZeVK/nFFdnsOxcZkf300Q37qLn5pVCLh2RCp2Un9r4topg== X-Gm-Gg: Acq92OGSA99rrNpe0hYlbP/zllmkf3n8AJYh3+tzyD5lWsd8GatZVyOO1inJMZq79/+ 37JwI2TEfU2Tyskvp8RaejIpR8evsRuRkVk7W3zrBoOTxtPwOFyOx/ZSvBn++vb32zaJDW7Q5s0 vG30+1I+kXWm5f3p/ArKpICRLCZWHu3z02u32XInBMwR5q1EIVZPUNq+LIxfjz5FbLIqTzFSDPM stGzt2kZMYTFFFhbyG14uxEMLo+8hrdfMqbONIfwTquuEQKYqvn7ZYgdHTDf73uPL/BsafsLZSO yOdQr2Y+KM/1Duw605Iu0bfdqewUqlC6G40FnU2d6VC5UX2mlxzIGueIRDtXdPhiCXFnACafbJe 0nfsN408gSzBWdanfmsbxRBHd2X2ct+4AGytiPgFW5F2WlzAMdlMfVF18RNG7Ikort5Q0jbE8qX YUd4xY X-Received: by 2002:a05:600c:6299:b0:486:d76c:fa57 with SMTP id 5b1f17b1804b1-48e706f11d0mr217927855e9.17.1778577863493; Tue, 12 May 2026 02:24:23 -0700 (PDT) X-Received: by 2002:a05:600c:6299:b0:486:d76c:fa57 with SMTP id 5b1f17b1804b1-48e706f11d0mr217927445e9.17.1778577863063; Tue, 12 May 2026 02:24:23 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e90536122sm35232405e9.4.2026.05.12.02.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2026 02:24:22 -0700 (PDT) From: Javier Martinez Canillas To: Maxime Ripard Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/bridge: it66121: Select HDMI or DVI mode based on sink type In-Reply-To: <20260511-gentle-grouse-of-growth-3ac263@houat> References: <20260510191459.90769-1-javierm@redhat.com> <20260510191459.90769-4-javierm@redhat.com> <20260511-spiritual-unique-uakari-5ffce7@houat> <877bpayuw7.fsf@ocarina.mail-host-address-is-not-set> <20260511-gentle-grouse-of-growth-3ac263@houat> Date: Tue, 12 May 2026 11:24:20 +0200 Message-ID: <87zf25x9ob.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Maxime Ripard writes: Hello Maxime, > Hi, > > On Mon, May 11, 2026 at 02:48:24PM +0200, Javier Martinez Canillas wrote: [...] >> >> I wrongly thought that couldn't get that info from it66121_bridge_mode_set() >> so I thought about making it a property of the bridge atomic state. >> >> But I see now that the connector is already stored in struct it66121_ctx *ctx >> so the fix indeed becomes even more trivial. > > Actually, there's something super fishy there. > > ctx->connector is stored only at atomic_enable time, but you'd be using > ctx->it at modeset time which is kind of decorelated to atomic_enable, > ctx->can be called multiple times, etc. > Your intuition was correct! The driver has a bug and ctx->connector seems to always be NULL because .mode_set is called before .atomic_enable, which is where the ctx->connector is being set. > It seems to be already used, so it probably works, but I don't think the > framework provides that guarantee. > It seems to work just because drm_hdmi_avi_infoframe_from_display_mode() allows the connector argument to be NULL, is just that the VIC data is not sent in the AVI infoframes if I understood correctly. I'll work on a v3 that moves the TX mode and AVI infoframes enable/disable to the .atomic_enable callback which I see is what other bridge drivers do (e.g,: sii902x). -- Best regards, Javier Martinez Canillas Core Platforms Red Hat