From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EFD01F1527 for ; Sat, 26 Jul 2025 16:50:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753548641; cv=none; b=FEDMKAR/ETCF+DaGcEhZqAf5X16SNYL63ozB8T6BVvmaYoQYBb7uhQxn+PrwPOvNP1inDjBmFKmSKaDJeMI+TA6o4T7hzEc0oj1tow5JVB7dpeOyfk52SDa4OwRY4ZMO3rYsRd+DYsvnyf6+FWciwoQito3nUhdD1W6FQvq5zSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753548641; c=relaxed/simple; bh=zDpIBHnyHepg3obhHPwbHPZ6/B84BaLrE2pLUyfYpsk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=L4lsUPdBJPc5jqybiEKl9cLjm1Cn9X/BCCIIlytMZ3XhA+H05SBGn9AzUL/RE8Q41hpgNe5PZWmWZJY0JFQgezs7RvCSIpFJDj30hUlt/PEehfmByUkYzLqV5Mi+dbsiFXkImVwygsEGjzUPN42znoP8mGHqITa0g1iUv52mTOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OSZVFW+z; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YqfEVXTw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=OSZVFW+z; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=YqfEVXTw; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OSZVFW+z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YqfEVXTw"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="OSZVFW+z"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="YqfEVXTw" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 313CA219E9; Sat, 26 Jul 2025 16:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753548632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEhiDTcKgxemrdqd09WTVsmXruXt1rZDsbRfz6qthKA=; b=OSZVFW+zBE+I3r2yZoP86GujVV5u/COUcUR+8ZMo1UeO2ffnePpHcM7exeH2Vfs8VfeL4D KHwHWA8dfKz0p8EnQgbLJb16ob41yk97IF8ox6Z/3S88QauHykLnSYDxAwyaGpxlmURuWP glOQCmlYmzECtveXISTnM3SYQ/RAbII= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753548632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEhiDTcKgxemrdqd09WTVsmXruXt1rZDsbRfz6qthKA=; b=YqfEVXTw6ECEVvYEqCH3SfeTLF8252M6+9bzm8NsOa47EgUbtwe8ezyUUwzG+j16NovVuj iiMymkKVLJLnEjDg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=OSZVFW+z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=YqfEVXTw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1753548632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEhiDTcKgxemrdqd09WTVsmXruXt1rZDsbRfz6qthKA=; b=OSZVFW+zBE+I3r2yZoP86GujVV5u/COUcUR+8ZMo1UeO2ffnePpHcM7exeH2Vfs8VfeL4D KHwHWA8dfKz0p8EnQgbLJb16ob41yk97IF8ox6Z/3S88QauHykLnSYDxAwyaGpxlmURuWP glOQCmlYmzECtveXISTnM3SYQ/RAbII= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1753548632; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LEhiDTcKgxemrdqd09WTVsmXruXt1rZDsbRfz6qthKA=; b=YqfEVXTw6ECEVvYEqCH3SfeTLF8252M6+9bzm8NsOa47EgUbtwe8ezyUUwzG+j16NovVuj iiMymkKVLJLnEjDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E2D381388B; Sat, 26 Jul 2025 16:50:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xcN5NVcHhWgbXgAAD6G6ig (envelope-from ); Sat, 26 Jul 2025 16:50:31 +0000 Date: Sat, 26 Jul 2025 18:50:31 +0200 Message-ID: <87zfcqvqug.wl-tiwai@suse.de> From: Takashi Iwai To: "Xu, Baojun" Cc: "broonie@kernel.org" , "andriy.shevchenko@linux.intel.com" , "alsa-devel@alsa-project.org" , "Ding, Shenghao" , "13916275206@139.com" <13916275206@139.com>, "P O, Vijeth" , "linux-sound@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH v2] ALSA: hda: Add TAS2770 support In-Reply-To: References: <20250723142423.38768-1-baojun.xu@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Level: * X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [1.29 / 50.00]; SEM_URIBL(3.50)[139.com:email]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; SUSPICIOUS_URL_IN_SUSPICIOUS_MESSAGE(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_DKIM_ALLOW(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[139.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[kernel.org,linux.intel.com,alsa-project.org,ti.com,139.com,vger.kernel.org]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; REDIRECTOR_URL(0.00)[proofpoint.com]; RCPT_COUNT_SEVEN(0.00)[9]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,suse.de:mid,suse.de:dkim,suse.de:email] X-Spamd-Bar: + X-Rspamd-Queue-Id: 313CA219E9 X-Spam-Score: 1.29 On Sat, 26 Jul 2025 13:34:28 +0200, Xu, Baojun wrote: > > > > > ________________________________________ > > From: Takashi Iwai > > Sent: 23 July 2025 22:40 > > To: Xu, Baojun > > Cc: broonie@kernel.org; andriy.shevchenko@linux.intel.com; alsa-devel@alsa-project.org; Ding, Shenghao; 13916275206@139.com; P O, Vijeth; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: [EXTERNAL] Re: [PATCH v2] ALSA: hda: Add TAS2770 support > > > > On Wed, 23 Jul 2025 16: 24: 23 +0200, Baojun Xu wrote: > > Add TAS2770 support in TI's HDA driver. And add hda_chip_id for > more products. Distinguish DSP and non-DSP in firmware > loading function. > > Signed-off-by: Baojun > > ZjQcmQRYFpfptBannerStart > > This message was sent from outside of Texas Instruments. > > Do not click links or open attachments unless you recognize the source of this email and know the content is safe. > > > > Report Suspicious > > > > ZjQcmQRYFpfptBannerEnd > > > > On Wed, 23 Jul 2025 16:24:23 +0200, > > Baojun Xu wrote: > > > > > > Add TAS2770 support in TI's HDA driver. And add hda_chip_id for > > > more products. Distinguish DSP and non-DSP in firmware > > > loading function. > > > > > > Signed-off-by: Baojun Xu > > > > Applied now, thanks. > > > > > > BTW, is include/sound/tas2770-tlv.h used by any other driver? > > (Also include/sound/tas2781-tlv.h). > > > > If those are used only by tas2781-hda-i2s/spi drivers, the files can > > be moved to sound/hda/codecs/side-codecs as local headers. > > > > In general, include/sound is rather for public headers that are read > > by multiple drivers in different places. > > Thanks for the apply! > Yes, include/sound/tasxxxx-tlv.h will also be used by other drivers > (for example, sound/soc/codecs/tas2xxx-i2c.c) OK, in that case, it's fine. thanks, Takashi