From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C7C326CE2A for ; Wed, 9 Jul 2025 08:22:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752049335; cv=none; b=KJnoyrotW5ZhhJLJCxYiK8en/Ov9VOQPPsXHA/+M99pjwjnahaaD4XPyrQYdMhwj1FYoPc0jw3OOVdOGBsXHlilZIPFbeo9KiH3xpivrDvcLGTeazfvpyrXeYHNGs07Bx8XAFONMWejPocvHe1/GKGiXx+Van3cH6zrjPCKmwHw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752049335; c=relaxed/simple; bh=bbp563xB+k02ZQyw0bOuD8J55G2HzTY7zLjAKvmY3ec=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ryQ3aWHI22xEBpkqDrkYgeSiDqpIXtUmq/1yKnQTZr14ZEUsuiKzaeV4gitAAtKoQOYPXR0ntdmhBYmvelC5HV5uuy2NOZHh70CuEA/QtNRT4e65jigd/w/zM6zCVdE5PeOH4fnD7YJdJPHj0EyCseg85oODsTqP7cYscsQrM5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=DXGtTvLo; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="DXGtTvLo" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ae36dc91dc7so931255766b.2 for ; Wed, 09 Jul 2025 01:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1752049332; x=1752654132; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=bFVNmahcL9ERzknhNwHAorX1ie7KJoJM18axXvqg5HA=; b=DXGtTvLoNo9ePfndqiQvjdbLT19QreUvafcDqWsaltkRvG9N7353sp3YvYuTjEKpI7 FRVYHtUITWrJwPC7YsdBNBNjyHq6U6l36Qp2zX5yFiCJ1LOn3K2U+Jl30ptasBSTvpKr ZJ59K/Ny1Qv9OWk0znGZSGZzr4WHY0nQIs0HuPfHjFo0Tb/CtTz6Hyc8G4p760gpwS/E X/s9bKxiLMMiT+zXUUVrnmNGR5LGGPxr2CKg5rAtszoydGpE7HbGvKfqYJdQ9ehIN62v eqsM3YAIuOrQ2i7c8DFkWUkLSJSmT3GyE1mQv0YXumEFJWosaOjdO+0UYotKIndnqDD/ 2nIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752049332; x=1752654132; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bFVNmahcL9ERzknhNwHAorX1ie7KJoJM18axXvqg5HA=; b=H1GWeXgQiDqBts1iNKqSHE81XrkD9Rgi3Jkx2x/yJr4Aq3wTxGkWHUQuVL2dxTkKJo RXvfZW+6iry3DH5bUhO+bSV/vF4ifCvLfFvzloREt1q5TwkC31c2nKpGNVRTEnD4+Il8 a5cx5YglXkzxQ+0MwGUYlfs2+Hs9gzW3DvjaRcjUhP0xYD/9b1DzjZRpof4WWiePnR9y AIfWPS7HtneYGxtY9g8nXYbelEHmQ08gzIhjYrFYk53FzCqPi2pYjUlr3u2dAGTnD9vy reLGhCNYhM1esD2iCT9TxidSNjCyunSnMrYpOxHB/XolCNN2fjZcucrGaWBW6UexowN+ boGw== X-Forwarded-Encrypted: i=1; AJvYcCUQh9s0ci8sWup4pZxzhEPadxIKumnoSb/lAlGSv7AanWovre72PtVaDmumKNjwrr1ACJbyefRqA6FeFzk=@vger.kernel.org X-Gm-Message-State: AOJu0YwA8LZmhgKBY5alrJ7UwU+VxqunLzdimFJ6oUfx4fMiyFRQo7l1 OTMx8aJWb+qsevx5Ia4zvem458CDAO9lRwH5HEr7fRG+Q/rv6wl8QhdPOIoUpgbuKaQ= X-Gm-Gg: ASbGnctmIMNxzEqDa95DU5fOw0bSSHZycgRAqg1ZH4qMfc4HdJl1zB/T99t3FB7c+2w rE2x6O66JN1ddrqUd7uZdI84nmd22ILTXh0669kXIHTaVQD6U46aahseNt7la4V/rz/vJDSdpaR ARo5ibfUshjL3lzs7aC+NijHrjNJv2CAV5OYzKDy6AIyM3icucJ6jRVbZSBhZcu7yxPuP72j2Yh BXicjxwlzay6VEv4OY0XBqTstrfV/I3OFosHHXrC0U2k58hDk5lI2CiK2kToV6cCqK1d3zO07AT f6FDLsdeQQ3B4+9z7UXDlJ3KHcs/oqjT/rZCp6LkNsmVNhNa+DT8uyY= X-Google-Smtp-Source: AGHT+IHhjLw7axM+sfg+4JbrvZ5uzjMQFSsgDBtJdAVL88Qnq4BGK12a+lUwgHht3jMZ3xAMt8/spQ== X-Received: by 2002:a17:906:c116:b0:ade:450a:695a with SMTP id a640c23a62f3a-ae6cfbea8f3mr137410866b.61.1752049331750; Wed, 09 Jul 2025 01:22:11 -0700 (PDT) Received: from cloudflare.com ([2a09:bac5:5063:2432::39b:b0]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-60fcb1f8856sm8372942a12.56.2025.07.09.01.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 01:22:11 -0700 (PDT) From: Jakub Sitnicki To: Tao Chen Cc: daniel@iogearbox.net, razor@blackwall.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, mattbobrowski@google.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, horms@kernel.org, willemb@google.com, pablo@netfilter.org, kadlec@netfilter.org, hawk@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org Subject: Re: [PATCH bpf-next v3 0/7] Add attach_type in bpf_link In-Reply-To: <20250709030802.850175-1-chen.dylane@linux.dev> (Tao Chen's message of "Wed, 9 Jul 2025 11:07:55 +0800") References: <20250709030802.850175-1-chen.dylane@linux.dev> Date: Wed, 09 Jul 2025 10:22:09 +0200 Message-ID: <87zfddepu6.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jul 09, 2025 at 11:07 AM +08, Tao Chen wrote: > Andrii suggested moving the attach_type into bpf_link, the previous discussion > is as follows: > https://lore.kernel.org/bpf/CAEf4BzY7TZRjxpCJM-+LYgEqe23YFj5Uv3isb7gat2-HU4OSng@mail.gmail.com > > patch1 add attach_type in bpf_link, and pass it to bpf_link_init, which > will init the attach_type field. > > patch2-7 remove the attach_type in struct bpf_xx_link, update the info > with bpf_link attach_type. > > There are some functions finally call bpf_link_init but do not have bpf_attr > from user or do not need to init attach_type from user like bpf_raw_tracepoint_open, > now use prog->expected_attach_type to init attach_type. > > bpf_struct_ops_map_update_elem > bpf_raw_tracepoint_open > bpf_struct_ops_test_run > > Feedback of any kind is welcome, thanks. > > Tao Chen (7): > bpf: Add attach_type in bpf_link > bpf: Remove attach_type in bpf_cgroup_link > bpf: Remove attach_type in sockmap_link > bpf: Remove location field in tcx_link > bpf: Remove attach_type in bpf_netns_link > bpf: Remove attach_type in bpf_tracing_link > netkit: Remove location field in netkit_link For the series: Reviewed-by: Jakub Sitnicki