From: Jonathan Corbet <corbet@lwn.net>
To: Jianhui Zhou <jianhuizz@qq.com>,
akpm@linux-foundation.org, paulmck@kernel.org,
jonaszhou@zhaoxin.com
Cc: thuth@redhat.com, rostedt@goodmis.org, david@redhat.com,
victor@mojatatu.com, andrii@kernel.org,
xiongwei.song@windriver.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Jianhui Zhou <jianhuizz@qq.com>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] Documentation: Remove the outdated prompt under cgroup_disable option in kernel-parameters.txt
Date: Thu, 09 Jan 2025 12:44:15 -0700 [thread overview]
Message-ID: <87zfjzkc1c.fsf@trenco.lwn.net> (raw)
In-Reply-To: <tencent_50D7C8F43461B5F8CF055C15970A1A36C305@qq.com>
It would have been good to include the cgroup maintainer here; adding
Tejun.
Looking at the code, it's far from clear to me that the other cgroups
pay attention to this parameter. Can somebody convince me that this
change is correct?
Thanks,
jon
Jianhui Zhou <jianhuizz@qq.com> writes:
> Disabling options other than memory is currently
> supported according to the cgroup_disable function.
> So it can be removed.
>
> Signed-off-by: Jianhui Zhou <jianhuizz@qq.com>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 3872bc6ec49d..3c562653016f 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -609,9 +609,6 @@
> - if foo is an optional feature then the feature is
> disabled and corresponding cgroup files are not
> created
> - {Currently only "memory" controller deal with this and
> - cut the overhead, others just disable the usage. So
> - only cgroup_disable=memory is actually worthy}
> Specifying "pressure" disables per-cgroup pressure
> stall information accounting feature
>
> --
> 2.25.1
next prev parent reply other threads:[~2025-01-09 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 9:52 Jianhui Zhou
2025-01-09 19:44 ` Jonathan Corbet [this message]
2025-01-09 20:22 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfjzkc1c.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=david@redhat.com \
--cc=jianhuizz@qq.com \
--cc=jonaszhou@zhaoxin.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=thuth@redhat.com \
--cc=tj@kernel.org \
--cc=victor@mojatatu.com \
--cc=xiongwei.song@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®