From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5BD43C25B41
	for <linux-kernel@archiver.kernel.org>; Mon, 23 Oct 2023 09:09:02 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229913AbjJWJJC (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 23 Oct 2023 05:09:02 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60670 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229498AbjJWJIy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2023 05:08:54 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D6298;
        Mon, 23 Oct 2023 02:08:51 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24111C433C8;
        Mon, 23 Oct 2023 09:08:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1698052131;
        bh=jwRsyL0IKugyJxiMd8kLsgpJe00BKc6ZBp9nnsSKdh8=;
        h=From:To:Cc:Subject:References:Date:In-Reply-To:From;
        b=fYhWq3tMJe5ZmbkFSfJ7QJdxNCXC3N996oh0H9CZpO/zYTlGkS9yuOamWKbktfKoG
         ObjHvauvkniDP+f/fk7s47NMI7wwQOQGVFQWv2/JfWAyEH6mGFARenFYfm+QMfZ36M
         20DZ4zdLoadEbR373pJFoYwBzFIVTlrKwV4CmSk4aggq+KSYJ5/idMRTKCT5oZmnvl
         Dm90Jz3OcYwpFPHOwtzZAqUV66OwRzYe7fvGm6bn0kaoR0BtKDOTOtT0CD4G7cnKQn
         VyhHT5ZGOafX0kngTAPkYN6kJTeUc+CZgKB+rK7xxXHGeuvNVkfwSPRvFu3d13dAye
         Wpu3S9cuZnBoA==
From:   Kalle Valo <kvalo@kernel.org>
To:     Chen Ni <nichen@iscas.ac.cn>
Cc:     gregory.greenman@intel.com, johannes.berg@intel.com,
        mukesh.sisodiya@intel.com, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: Add check for kmemdup
References: <20231023064501.274599-1-nichen@iscas.ac.cn>
Date:   Mon, 23 Oct 2023 12:08:48 +0300
In-Reply-To: <20231023064501.274599-1-nichen@iscas.ac.cn> (Chen Ni's message
        of "Mon, 23 Oct 2023 06:45:01 +0000")
Message-ID: <87zg09zowv.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Chen Ni <nichen@iscas.ac.cn> writes:

> Since the kmemdup may return NULL pointer,
> it should be better to add check for the return value
> in order to avoid NULL pointer dereference.
>
> Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once
> fw dump occurred")

The fixes tag should be in one line.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches