From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA852C0015E for ; Fri, 11 Aug 2023 07:21:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231754AbjHKHVP (ORCPT ); Fri, 11 Aug 2023 03:21:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjHKHVM (ORCPT ); Fri, 11 Aug 2023 03:21:12 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5F3E2738; Fri, 11 Aug 2023 00:21:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A40C321866; Fri, 11 Aug 2023 07:21:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1691738470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZXMP9POMv7KC+x9VLPOTS3Ne+HZSWG0MHLcv2J5N8A=; b=SAgbd3j6VOuQvwrdCPVTkR6xG30eF5BLitxscOvRMjlsSwfQ0pkuMEcl2EAayc3i3w4BG7 aHP+PUDtJ9mH6cZcCVKn17XQZkJYPps4XPG5ZEvS4n8VSEKYjvatHflSINSYRI7+2D3Npw NhNV7lytfBeshmAnc5A8XZbEXSo7c4w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1691738470; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZXMP9POMv7KC+x9VLPOTS3Ne+HZSWG0MHLcv2J5N8A=; b=SM24BEBRjSyUqJmEUK4lplbTaB1VAsISkR7KpU0BSZVnUrsXZ0DYsoo5D5zTZqc49jgB1f +P+waw3vZK/5YrDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 750FD138E2; Fri, 11 Aug 2023 07:21:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id iKmYG2bh1WQ2YwAAMHmgww (envelope-from ); Fri, 11 Aug 2023 07:21:10 +0000 Date: Fri, 11 Aug 2023 09:21:09 +0200 Message-ID: <87zg2yrqmy.wl-tiwai@suse.de> From: Takashi Iwai To: Jarkko Sakkinen Cc: linux-integrity@vger.kernel.org, Linus Torvalds , stable@vger.kernel.org, "Takashi Iwai" , Lino Sanfilippo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts categorically for Lenovo In-Reply-To: <20230810182433.518523-1-jarkko@kernel.org> References: <20230810182433.518523-1-jarkko@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Aug 2023 20:24:33 +0200, Jarkko Sakkinen wrote: > > By large most of the entries in tpm_tis_dmi_table[] are for Lenovo laptops, > and they keep on coming. Therefore, disable IRQs categorically for Lenovo. > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test") > Cc: # v6.4+ > Reported-by: "Takashi Iwai" > Closes: https://lore.kernel.org/linux-integrity/87il9qhxjq.wl-tiwai@suse.de/ > Signed-off-by: Jarkko Sakkinen > --- > This will be included into v6.5-rc6 PR, as long as Takashi ack's it. I'm > planning to send tomorrow morning (GMT+3). Feel free to take my ack: Acked-by: Takashi Iwai I'll build a test kernel and ask reporters for testing the fix, too. Thanks! Takashi > > BR, Jarkko > drivers/char/tpm/tpm_tis.c | 34 ---------------------------------- > 1 file changed, 34 deletions(-) > > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c > index 3c0f68b9e44f..dd0f52d35073 100644 > --- a/drivers/char/tpm/tpm_tis.c > +++ b/drivers/char/tpm/tpm_tis.c > @@ -132,42 +132,8 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = { > }, > { > .callback = tpm_tis_disable_irq, > - .ident = "ThinkPad T490s", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T490s"), > - }, > - }, > - { > - .callback = tpm_tis_disable_irq, > - .ident = "ThinkStation P360 Tiny", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkStation P360 Tiny"), > - }, > - }, > - { > - .callback = tpm_tis_disable_irq, > - .ident = "ThinkPad L490", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L490"), > - }, > - }, > - { > - .callback = tpm_tis_disable_irq, > - .ident = "ThinkPad L590", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad L590"), > - }, > - }, > - { > - .callback = tpm_tis_disable_irq, > - .ident = "ThinkStation P620", > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > - DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkStation P620"), > }, > }, > { > -- > 2.39.2 >