From: Florian Weimer <fweimer@redhat.com>
To: Harald van Dijk <harald@gigawatt.nl>
Cc: Andy Lutomirski <luto@kernel.org>,
Jessica Clarke <jrtc27@jrtc27.com>, Rich Felker <dalias@libc.org>,
linux-x86_64@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] x86: Fix x32 System V message queue syscalls
Date: Tue, 01 Aug 2023 09:15:06 +0200 [thread overview]
Message-ID: <87zg3b5j45.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <347eab9f-b64a-b124-ba7a-ee458e6407f3@gigawatt.nl> (Harald van Dijk's message of "Tue, 1 Aug 2023 01:43:40 +0100")
* Harald van Dijk:
> There is one complication that I think has not been mentioned yet:
> when _GNU_SOURCE is defined, glibc does provide a definition of struct
> msghdr in <sys/msg.h> with a field "__syscall_slong_t mtype;". This
> makes it slightly more likely that there is code out there in the wild
> that works fine with current kernels and would be broken by the
> fix. Given how rare x32 is, and how rare message queues are, this may
> still be acceptable, but I am mentioning it just in case this would
> cause a different approach to be preferred. And whatever is done, a
> fix should also be submitted to glibc.
What should glibc do here? Just change the definition in the header to
long and ignore the breakage?
Thanks,
Florian
next prev parent reply other threads:[~2023-08-01 7:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 1:48 [PATCH] " Jessica Clarke
2020-10-12 3:02 ` Andy Lutomirski
2020-10-12 3:31 ` Jessica Clarke
2020-10-12 13:44 ` [PATCH v2] " Jessica Clarke
2020-10-30 19:21 ` Jessica Clarke
2020-10-31 23:30 ` Andy Lutomirski
2020-11-01 0:09 ` Jessica Clarke
2020-11-01 1:22 ` Rich Felker
2020-11-01 1:27 ` Jessica Clarke
2020-11-01 1:50 ` Rich Felker
2020-11-01 18:07 ` Andy Lutomirski
2020-11-01 18:15 ` Jessica Clarke
2020-11-01 18:27 ` Jessica Clarke
2020-11-01 21:01 ` Rich Felker
2020-11-16 0:55 ` Jessica Clarke
2020-12-06 0:01 ` Jessica Clarke
2020-12-06 22:55 ` Andy Lutomirski
2023-08-01 0:43 ` Harald van Dijk
2023-08-01 1:38 ` Jessica Clarke
2023-08-01 2:53 ` Rich Felker
2023-08-01 12:13 ` Harald van Dijk
2023-09-10 23:33 ` [PATCH 1/2] uapi: Stop using __kernel_long_t in struct msgbuf Harald van Dijk
2023-09-10 23:33 ` [PATCH 2/2] uapi: Remove struct msgbuf, struct ipc_kludge Harald van Dijk
2023-08-01 7:15 ` Florian Weimer [this message]
2023-08-01 12:15 ` [PATCH v2] x86: Fix x32 System V message queue syscalls Harald van Dijk
2023-09-10 23:40 ` Harald van Dijk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg3b5j45.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=bp@alien8.de \
--cc=dalias@libc.org \
--cc=harald@gigawatt.nl \
--cc=hpa@zytor.com \
--cc=jrtc27@jrtc27.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x86_64@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®