From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F98C77B73 for ; Mon, 5 Jun 2023 07:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230342AbjFEHVa (ORCPT ); Mon, 5 Jun 2023 03:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbjFEHV1 (ORCPT ); Mon, 5 Jun 2023 03:21:27 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD786BD for ; Mon, 5 Jun 2023 00:21:26 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 74E9F1F8AE; Mon, 5 Jun 2023 07:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1685949685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UYDbnuU9fxM3O749pKYl9Dg/BsDW7P3xdvEx+Q4AYYA=; b=GLlHDA3Mjnv2FZkoS1Fr+X/G42wTIB30Sf8urcZ4QAmcFimlS1x/URNy2c8ayc1RrENS1J +gXQRkWOd2/cSWDf36xqO0T2j8Z/BjXm+AcVqe7l2OMrDtu2Tzs2JkgzMevv+F1Vtlxd5B EhHQASC0K9C6q7vZWA7byLT0zZNEYTY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1685949685; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UYDbnuU9fxM3O749pKYl9Dg/BsDW7P3xdvEx+Q4AYYA=; b=cjKJXDE8KtGJsBeGabZtD/r2XBSy2JIqD//MJMQPIEAfun+gK/MADSxi6RoWRJBKGhSQc9 7ycWLci6pPBXJqBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4BADC139C7; Mon, 5 Jun 2023 07:21:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9QGQEfWMfWSzaAAAMHmgww (envelope-from ); Mon, 05 Jun 2023 07:21:25 +0000 Date: Mon, 05 Jun 2023 09:21:24 +0200 Message-ID: <87zg5eidcb.wl-tiwai@suse.de> From: Takashi Iwai To: Stefan Binding Cc: Jaroslav Kysela , Takashi Iwai , , , Subject: Re: [PATCH RESEND v1 2/3] ALSA: hda: cs35l41: Fix endian conversions In-Reply-To: <20230525135955.2108140-3-sbinding@opensource.cirrus.com> References: <20230525135955.2108140-1-sbinding@opensource.cirrus.com> <20230525135955.2108140-3-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2023 15:59:54 +0200, Stefan Binding wrote: > > @@ -379,10 +379,10 @@ static int cs35l41_save_calibration(struct cs35l41_hda *cs35l41) > > /* Calibration can only be applied whilst the DSP is not running */ > ret = cs35l41_apply_calibration(cs35l41, > - cpu_to_be32(cl->calAmbient), > - cpu_to_be32(cl->calR), > - cpu_to_be32(cl->calStatus), > - cpu_to_be32(cl->calR + 1)); > + (__be32)cpu_to_be32(cl->calAmbient), > + (__be32)cpu_to_be32(cl->calR), > + (__be32)cpu_to_be32(cl->calStatus), > + (__be32)cpu_to_be32(cl->calR + 1)); Do we really need those cast? Even if yes, it must be with __force prefix for the endian cast in general. thanks, Takashi