mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Gao Xiang <hsiangkao@redhat.com>, linux-doc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Gao Xiang <hsiangkao@redhat.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Zefan Li <lizefan.x@bytedance.com>
Subject: Re: [PATCH] Documentation: sysrq: update description about sysrq crash
Date: Mon, 15 Mar 2021 14:23:39 -0600	[thread overview]
Message-ID: <87zgz4yxmc.fsf@meer.lwn.net> (raw)
In-Reply-To: <20210309191550.3955601-1-hsiangkao@redhat.com>

Gao Xiang <hsiangkao@redhat.com> writes:

> After commit 8341f2f222d7 ("sysrq: Use panic() to force a crash"),
> a crash was not generated by dereferencing a NULL pointer anymore.
>
> Let's update documentation as well to make it less misleading.
>
> Cc: Matthias Kaehlcke <mka@chromium.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jonathan Corbet <corbet@lwn.net>
> Cc: Zefan Li <lizefan.x@bytedance.com>
> Signed-off-by: Gao Xiang <hsiangkao@redhat.com>
> ---
>  Documentation/admin-guide/sysrq.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/admin-guide/sysrq.rst b/Documentation/admin-guide/sysrq.rst
> index 67dfa4c29093..60ce5f5ebab6 100644
> --- a/Documentation/admin-guide/sysrq.rst
> +++ b/Documentation/admin-guide/sysrq.rst
> @@ -90,8 +90,8 @@ Command	    Function
>  ``b``	    Will immediately reboot the system without syncing or unmounting
>              your disks.
>  
> -``c``	    Will perform a system crash by a NULL pointer dereference.
> -            A crashdump will be taken if configured.
> +``c``	    Will perform a system crash and a crashdump will be taken
> +            if configured.

Makes sense. Applied, thanks.

jon

      reply	other threads:[~2021-03-15 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 19:15 Gao Xiang
2021-03-15 20:23 ` Jonathan Corbet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgz4yxmc.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsiangkao@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mka@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®