From: Thomas Gleixner <tglx@linutronix.de>
To: Max Filippov <jcmvbkbc@gmail.com>, linux-xtensa@linux-xtensa.org
Cc: Chris Zankel <chris@zankel.net>,
linux-kernel@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>
Subject: Re: [PATCH] highmem: fix highmem for xtensa
Date: Fri, 13 Nov 2020 14:40:43 +0100 [thread overview]
Message-ID: <87zh3ll6hw.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20201113122328.22942-1-jcmvbkbc@gmail.com>
Max,
On Fri, Nov 13 2020 at 04:23, Max Filippov wrote:
> Fixmap on xtensa grows upwards, i.e. bigger fixmap entry index
> corresponds to a higher virtual address. This was lost in highmem
> generalization resulting in the following runtime warnings:
Sorry for not noticing.
> Fix it by adding __ARCH_HAS_POSITIVE_FIXMAP macro and implementing
> vaddr_in_fixmap and fixmap_pte primitives differently depending on
> whether it is defined or not.
What's wrong with just doing the obvious and making the fixmap defines
the other way round?
Thanks,
tglx
---
diff --git a/arch/xtensa/include/asm/fixmap.h b/arch/xtensa/include/asm/fixmap.h
index 92049b61c351..ee17e46f3b44 100644
--- a/arch/xtensa/include/asm/fixmap.h
+++ b/arch/xtensa/include/asm/fixmap.h
@@ -37,8 +37,8 @@
enum fixed_addresses {
#ifdef CONFIG_HIGHMEM
/* reserved pte's for temporary kernel mappings */
- FIX_KMAP_BEGIN,
- FIX_KMAP_END = FIX_KMAP_BEGIN +
+ FIX_KMAP_END,
+ FIX_KMAP_BEGIN = FIX_KMAP_END +
(KM_MAX_IDX * NR_CPUS * DCACHE_N_COLORS) - 1,
#endif
__end_of_fixed_addresses
next prev parent reply other threads:[~2020-11-13 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 12:23 Max Filippov
2020-11-13 13:40 ` Thomas Gleixner [this message]
2020-11-13 13:50 ` Max Filippov
2020-11-13 14:36 ` Thomas Gleixner
2020-11-13 16:34 ` Max Filippov
2020-11-13 22:34 ` Thomas Gleixner
2020-11-16 14:47 ` Max Filippov
2020-11-16 17:37 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh3ll6hw.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=chris@zankel.net \
--cc=jcmvbkbc@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome