From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Tingwei Zhang <tingwei@codeaurora.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Cc: Tingwei Zhang <tingwei@codeaurora.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
tsoni@codeaurora.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Mao Jinlong <jinlmao@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU
Date: Fri, 18 Sep 2020 15:45:52 +0300 [thread overview]
Message-ID: <87zh5nw8vz.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200903001706.28147-7-tingwei@codeaurora.org>
Tingwei Zhang <tingwei@codeaurora.org> writes:
> @@ -63,6 +65,7 @@ static int __init stm_ftrace_init(void)
> {
> int ret;
>
> + stm_ftrace.data.nr_chans = num_possible_cpus();
Not a problem with this patch necesarily, but this made me realize that
.nr_chans may be larger than:
(1) what the policy permits,
(2) what the stm device can handle.
While (1) the user can fix in the policy, they won't be able to fix (2),
in which case they won't be able to use stm_ftrace at all. I'm thinking
if a link-time callback would be good enough.
Another thing is that .nr_chans needs to be a power of 2 at the moment.
Regards,
--
Alex
next prev parent reply other threads:[~2020-09-18 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 0:17 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 1/6] stm class: ftrace: change dependency to TRACING Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 2/6] tracing: add flag to control different traces Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 3/6] tracing: add trace_export support for event trace Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 4/6] tracing: add trace_export support for trace_marker Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 5/6] stm class: ftrace: enable supported trace export flag Tingwei Zhang
2020-09-03 0:17 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-09-18 12:45 ` Alexander Shishkin [this message]
2020-09-23 4:39 ` Tingwei Zhang
2020-09-14 23:27 ` [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-09-18 14:26 ` Alexander Shishkin
-- strict thread matches above, loose matches on Subject: below --
2020-08-13 1:45 Tingwei Zhang
2020-08-13 1:45 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-08-11 3:57 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-08-11 3:57 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
2020-07-28 1:33 [PATCH v3 0/6] tracing: export event trace and trace_marker Tingwei Zhang
2020-07-28 1:33 ` [PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU Tingwei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zh5nw8vz.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=jinlmao@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suzuki.poulose@arm.com \
--cc=tingwei@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®