From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: John Johansen <john.johansen@canonical.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Seth Arnold <seth.arnold@canonical.com>,
Matthew Garrett <mjg59@google.com>,
Kees Cook <keescook@chromium.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apparmor: remove unused label
Date: Thu, 23 Aug 2018 11:41:36 -0300 [thread overview]
Message-ID: <87zhxdrvq7.fsf@morokweng.localdomain> (raw)
In-Reply-To: <20180823140917.3060915-1-arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> writes:
> After the corresponding 'goto' was removed, we get a warning
> for the 'fail' label:
>
> security/apparmor/policy_unpack.c: In function 'unpack_dfa':
> security/apparmor/policy_unpack.c:426:1: error: label 'fail' defined but not used [-Werror=unused-label]
>
> Fixes: fb5841091f28 ("apparmor: remove no-op permission check in policy_unpack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> security/apparmor/policy_unpack.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
> index 3647b5834ace..96d8cf68ce65 100644
> --- a/security/apparmor/policy_unpack.c
> +++ b/security/apparmor/policy_unpack.c
> @@ -423,7 +423,6 @@ static struct aa_dfa *unpack_dfa(struct aa_ext *e)
>
> return dfa;
>
> -fail:
> aa_put_dfa(dfa);
> return ERR_PTR(-EPROTO);
> }
Shouldn't the two lines after the label be removed as well? IIUC they're
unreachable now.
--
Thiago Jung Bauermann
IBM Linux Technology Center
next prev parent reply other threads:[~2018-08-23 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 14:09 Arnd Bergmann
2018-08-23 14:21 ` Kees Cook
2018-08-23 14:28 ` Tetsuo Handa
2018-08-23 14:41 ` Thiago Jung Bauermann [this message]
2018-08-23 18:21 ` John Johansen
2018-08-23 21:30 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhxdrvq7.fsf@morokweng.localdomain \
--to=bauerman@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mjg59@google.com \
--cc=serge@hallyn.com \
--cc=seth.arnold@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®