From: Michael Ellerman <mpe@ellerman.id.au>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Josef Bacik <jbacik@fb.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/2] powerpc: Add support for function error injection
Date: Fri, 01 Jun 2018 00:13:44 +1000 [thread overview]
Message-ID: <87zi0fyktj.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <1527761352.z5jz8jg2d5.naveen@linux.ibm.com>
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
> Michael Ellerman wrote:
>> "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> writes:
>>> ...
>>
>> A change log is always nice even if it's short :)
>
> I tried, but really couldn't come up with anything more to write. I'll
> try harder for v2 :)
Yeah true.
You could just say "All that's required is to define x and y and select
the Kconfig symbol".
>> This looks fine to me, it's probably easiest if it goes in via tip along
>> with patch 1.
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Thanks for the review. I'll base v2 on -tip
I guess if it doesn't already apply to tip you should rebase it. You've
probably missed 4.18 anyway.
cheers
next prev parent reply other threads:[~2018-05-31 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 12:36 [PATCH 0/2] error-injection: simplify code and powerpc support Naveen N. Rao
2018-05-29 12:36 ` [PATCH 1/2] error-injection: Simplify arch specific helpers Naveen N. Rao
2018-05-30 8:41 ` Masami Hiramatsu
2018-05-31 10:09 ` Naveen N. Rao
2018-06-01 23:12 ` Masami Hiramatsu
2018-05-29 12:36 ` [PATCH 2/2] powerpc: Add support for function error injection Naveen N. Rao
2018-05-31 4:57 ` Michael Ellerman
2018-05-31 10:11 ` Naveen N. Rao
2018-05-31 14:13 ` Michael Ellerman [this message]
2018-05-31 19:06 ` Naveen N. Rao
2018-06-06 10:38 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi0fyktj.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=jbacik@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®