From: Michael Ellerman <mpe@ellerman.id.au>
To: Guenter Roeck <linux@roeck-us.net>,
Murilo Opsfelder Araujo <mopsfelder@gmail.com>,
linux-kernel@vger.kernel.org
Cc: linux-watchdog@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [PATCH] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
Date: Mon, 29 May 2017 12:08:16 +1000 [thread overview]
Message-ID: <87zidw76un.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <2c95ae14-06a7-d3c2-aabb-1e164eb6b6e9@roeck-us.net>
Guenter Roeck <linux@roeck-us.net> writes:
> On 05/26/2017 06:22 PM, Murilo Opsfelder Araujo wrote:
>> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
>> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
>> setting CONFIG_PPC_RTAS throws the following errors:
>>
>> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
>> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>>
>> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
>> CONFIG_PPC_RTAS was not set. Logs are here:
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>>
>> This patch fixes the issue by selecting CONFIG_PPC_RTAS when
>> CONFIG_WATCHDOG_RTAS is set.
>>
>> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
>> ---
>> drivers/watchdog/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 8b9049d..5d872145 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -1689,6 +1689,7 @@ config MEN_A21_WDT
>> config WATCHDOG_RTAS
>> tristate "RTAS watchdog"
>> depends on PPC_RTAS || (PPC64 && COMPILE_TEST)
>> + select PPC_RTAS
>
> This can not at the same time depend on PPC_RTAS and select it.
> Guess we'll have to drop COMPILE_TEST entirely.
We could stub out the RTAS pieces it needs. But I don't think it buys us
much, for compile testing you may as well just build a config which has
PPC_RTAS enabled, there are several.
So I think it should just depend on PPC_RTAS.
Murilo can you send a v2?
cheers
next prev parent reply other threads:[~2017-05-29 2:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-27 1:22 Murilo Opsfelder Araujo
2017-05-27 1:53 ` Guenter Roeck
2017-05-29 2:08 ` Michael Ellerman [this message]
2017-05-29 13:30 ` Murilo Opsfelder Araújo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zidw76un.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mopsfelder@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®