From: Michael Ellerman <mpe@ellerman.id.au>
To: Pavel Machek <pavel@denx.de>, Andrew Morton <akpm@linux-foundation.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
trivial@kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, paulus@samba.org,
Andrew Morton <akpm@osdl.org>,
jwboyer@linux.vnet.ibm.com, sr@denx.de,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/sequoia: fix NAND partitions not to overlap
Date: Fri, 19 May 2017 20:04:29 +1000 [thread overview]
Message-ID: <87zie95fiq.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <87efvl75ts.fsf@concordia.ellerman.id.au>
Michael Ellerman <mpe@ellerman.id.au> writes:
> Pavel Machek <pavel@denx.de> writes:
>
>> On Wed 2017-05-17 14:37:17, Andrew Morton wrote:
>>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote:
>>>
>>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote:
>>> > > Fix overlapping NAND partitions.
>>> > >
>>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>>> >
>>> > Ping? Two partitions at same place are bad news...
>>>
>>> Please expand on "bad news"? What are the runtime effects of this
>>> change? Decisions about which kernel(s) to patch depend on this info.
>>
>> Well... two partitions at same place. If you use one, you will corrupt
>> information on the other one.
>>
>> OTOH this moves partition around (so that they don't overlap) so it is
>> probably not stable candidate.
>>
>> I guess this is not huge issue; people using these boards probably
>> have custom dts changes, anyway...
>
> Or no one's even using it anymore.
>
> I can take this via powerpc, I won't mark it for stable etc.
It became:
Author: Pavel Machek <pavel@denx.de>
powerpc/sequoia: Fix NAND partitions not to overlap
Currently the DTS defines two partitions at the same addresses, if you
use one, you will corrupt information on the other one. Fix it by
shifting the second partition.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
[mpe: Reconstruct change log from email thread]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Minor nit, your From: address doesn't match your Signed-off-by: address,
which trips my "check patch is signed-off-by author" script. I can
just ignore it, but I think it's preferable if they match.
cheers
next prev parent reply other threads:[~2017-05-19 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 10:05 Pavel Machek
2017-05-17 12:06 ` Pavel Machek
2017-05-17 21:37 ` Andrew Morton
2017-05-18 9:48 ` Pavel Machek
2017-05-19 5:50 ` Michael Ellerman
2017-05-19 9:12 ` Pavel Machek
2017-05-19 10:04 ` Michael Ellerman [this message]
2017-05-19 11:18 ` Pavel Machek
2017-05-22 9:12 ` Michael Ellerman
2017-05-30 9:11 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zie95fiq.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=akpm@osdl.org \
--cc=devicetree@vger.kernel.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=paulus@samba.org \
--cc=pavel@denx.de \
--cc=robh+dt@kernel.org \
--cc=sr@denx.de \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®