From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757315AbdAJX1Y (ORCPT ); Tue, 10 Jan 2017 18:27:24 -0500 Received: from out01.mta.xmission.com ([166.70.13.231]:44168 "EHLO out01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756867AbdAJX1T (ORCPT ); Tue, 10 Jan 2017 18:27:19 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Al Viro Cc: Linus Torvalds , Linux Containers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <87d1fzzbc2.fsf@xmission.com> <20170107062952.GH1555@ZenIV.linux.org.uk> <20170107064012.GI1555@ZenIV.linux.org.uk> Date: Wed, 11 Jan 2017 12:23:18 +1300 In-Reply-To: <20170107064012.GI1555@ZenIV.linux.org.uk> (Al Viro's message of "Sat, 7 Jan 2017 06:40:13 +0000") Message-ID: <87ziiyijo9.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1cR5oy-0000zD-Lj;;;mid=<87ziiyijo9.fsf@xmission.com>;;;hst=in01.mta.xmission.com;;;ip=101.100.131.98;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX19afvbXBMO3qWheRpJEYtukB1kE/dxrOUk= X-SA-Exim-Connect-IP: 101.100.131.98 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa01 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 1.2 XMSubMetaSxObfu_03 Obfuscated Sexy Noun-People * 1.0 XMSubMetaSx_00 1+ Sexy Words X-Spam-DCC: XMission; sa01 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Al Viro X-Spam-Relay-Country: X-Spam-Timing: total 403 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 6 (1.6%), b_tie_ro: 5 (1.3%), parse: 1.25 (0.3%), extract_message_metadata: 26 (6.4%), get_uri_detail_list: 1.87 (0.5%), tests_pri_-1000: 11 (2.7%), tests_pri_-950: 2.0 (0.5%), tests_pri_-900: 1.60 (0.4%), tests_pri_-400: 35 (8.7%), check_bayes: 33 (8.2%), b_tokenize: 10 (2.4%), b_tok_get_all: 8 (1.9%), b_comp_prob: 4.2 (1.0%), b_tok_touch_all: 7 (1.8%), b_finish: 0.95 (0.2%), tests_pri_0: 307 (76.2%), check_dkim_signature: 0.86 (0.2%), check_dkim_adsp: 4.4 (1.1%), tests_pri_500: 7 (1.9%), rewrite_mail: 0.00 (0.0%) Subject: Re: [GIT PULL] namespace related fixes for 4.10-rc3 X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Al Viro writes: > On Sat, Jan 07, 2017 at 06:29:52AM +0000, Al Viro wrote: >> On Sat, Jan 07, 2017 at 06:30:05PM +1300, Eric W. Biederman wrote: >> >> > Eric W. Biederman (3): >> > mnt: Protect the mountpoint hashtable with mount_lock >> ACK >> >> > mnt: Tuck mounts under others instead of creating shadow/side mounts. >> >> NAK; you have reintroduced put_mountpoint() outside of mount lock in there >> and you've got seriously confused umount side of the things. > > PS: details are in my reply (admittedly, sent only ~20 minutes > before your pull request) to your patch. Check Message-ID > <20170107050644.GA12074@ZenIV.linux.org.uk> I suspect that was sent while I was composing my pull request, and the locking around put_mountpoint I did fail to catch during my rebase. I will finish our conversation about that before I resend that patch. > My apologies for not getting to it yesterday (the patch was posted a couple of > days ago, AFAICS) - I'd been off-net since Wednesday, just got back > ;-/ You and Ram Pai had said reasonably pleasant things about a previous version of that patch. Eric