From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932414AbcGLAY0 (ORCPT ); Mon, 11 Jul 2016 20:24:26 -0400 Received: from anholt.net ([50.246.234.109]:58666 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088AbcGLAYZ (ORCPT ); Mon, 11 Jul 2016 20:24:25 -0400 From: Eric Anholt To: Colin King , David Airlie , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: remove redundant ret status check In-Reply-To: <1468103163-6588-1-git-send-email-colin.king@canonical.com> References: <1468103163-6588-1-git-send-email-colin.king@canonical.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Mon, 11 Jul 2016 17:24:21 -0700 Message-ID: <87zipn1z62.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Colin King writes: > From: Colin Ian King > > At the current point where ret is being checked for non-zero it has > not changed since it was initialized to zero, hence the check and the > label unref are redundant and can be removed. Reviewed-by: Eric Anholt I'll put this in my next pull request. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJXhDi1AAoJELXWKTbR/J7o/zoP/2itFrlzskhtfLRl9GdUAQTH bZdmzOYDFCN+aSc1bVPS4T9owW/GVB2IaheQpXIVNH7ONY5Y9/jiTDqjgegCdDUj gOGkwnCG7pYp1B4dyZ/LVjwu+STbKnjJ1JNGvsUUdIT0wrUZORo23i9oix3Yhklm f4A9zQHkEnn5dfrv9aKmpcs7q2pw57vwmiwHKa6BSlFBzO2pCmv0wjhdFNPjQuTp gk/c0q5b/APLkYg7yHf6v3lB0iOCPRiV5l6T3e+FabhkY+vNK1+SpZN4g7Qn4py/ oyxYIN+6DYVHn1on+iIu8bng5qn+giBLEIY9jxnDabcyvuQeze7U2mnuzRxrA5jl BIfviQ7JV4x+G10IPN/0tJQA7zeP2KU/4WmD1Y3PktF6Q8D4V6GIZM6VeiAdv7My g/3xhNfhYkpF96CY0O/8JwNSPlrUwigwKMvdGOR/4VNeFORjb9H1N65jHNeexe6L xfXPIdL1AN20pdbq03aOYAMEOx6jSJ55fPz/ga30+SGg67vMPCfEsS4p7x52ffMr gI3ArkRckgLnphJxQ/s/syULuRpWi21PpnohEUeu98aiE29GdKsnfomEK216b9/P dlrH46HAjouz6k+vUMzxrRRLH63QLlmaRaGQBPUEwXEzp0QkfMGVnmPjE2VTOET/ RiOhB9vOPJcsGCdpD3CZ =gJ+l -----END PGP SIGNATURE----- --=-=-=--