From: Punit Agrawal <punit.agrawal@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
bskeggs@redhat.com, airlied@linux.ie,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] drm/nouveau/fb/nv50: set DMA mask before mapping scratch page
Date: Thu, 23 Jun 2016 13:57:42 +0100 [thread overview]
Message-ID: <87ziqc2hbt.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAKv+Gu8uZ38JLKJLey5RD+0g+_zJ9xZU+0UaopeRmriho030ug@mail.gmail.com> (Ard Biesheuvel's message of "Thu, 23 Jun 2016 12:07:58 +0200")
Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
> On 23 June 2016 at 11:55, Punit Agrawal <punit.agrawal@arm.com> wrote:
>> Ard Biesheuvel <ard.biesheuvel@linaro.org> writes:
>>
>>> The 100c08 scratch page is mapped using dma_map_page() before the TTM
>>> layer has had a chance to set the DMA mask. This means we are still
>>> running with the default of 32 when this code executes, and this causes
>>> problems for platforms with no memory below 4 GB (such as AMD Seattle)
>>>
>>> So move the dma_map_page() to the .init hook, and set the streaming DMA
>>> mask based on the MMU subdev parameters before performing the call.
>>>
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>> Hi Ard,
>>
>> Thanks for posting this patch.
>>
>> With the patch, I am able to see console output on a screen attached to
>> the NVS 300 PCIe card in an AMD Seattle system. It was failing with
>> a message similar to what you've posted below.
>>
>
> Thanks for the report. May I take it as a tested-by?
Sure.
Punit
[...]
prev parent reply other threads:[~2016-06-23 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 12:30 Ard Biesheuvel
2016-06-23 9:55 ` Punit Agrawal
2016-06-23 10:07 ` Ard Biesheuvel
2016-06-23 12:57 ` Punit Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziqc2hbt.fsf@e105922-lin.cambridge.arm.com \
--to=punit.agrawal@arm.com \
--cc=airlied@linux.ie \
--cc=ard.biesheuvel@linaro.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®