From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751798AbbJAIX2 (ORCPT ); Thu, 1 Oct 2015 04:23:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:44981 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755996AbbJAIXV (ORCPT ); Thu, 1 Oct 2015 04:23:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,616,1437462000"; d="scan'208";a="816926143" From: Jani Nikula To: Rasmus Villemoes , David Airlie Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] vgaarb: use kzalloc in vga_arbiter_add_pci_device() In-Reply-To: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1443643027-4301-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Notmuch/0.20.2+101~gb57168b (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Thu, 01 Oct 2015 11:26:40 +0300 Message-ID: <87zj03ata7.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Rasmus Villemoes wrote: > Signed-off-by: Rasmus Villemoes Reviewed-by: Jani Nikula > --- > drivers/gpu/vga/vgaarb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c > index a0b433456107..3166e4bc4eb6 100644 > --- a/drivers/gpu/vga/vgaarb.c > +++ b/drivers/gpu/vga/vgaarb.c > @@ -531,7 +531,7 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) > return false; > > /* Allocate structure */ > - vgadev = kmalloc(sizeof(struct vga_device), GFP_KERNEL); > + vgadev = kzalloc(sizeof(struct vga_device), GFP_KERNEL); > if (vgadev == NULL) { > pr_err("failed to allocate pci device\n"); > /* > @@ -541,8 +541,6 @@ static bool vga_arbiter_add_pci_device(struct pci_dev *pdev) > return false; > } > > - memset(vgadev, 0, sizeof(*vgadev)); > - > /* Take lock & check for duplicates */ > spin_lock_irqsave(&vga_lock, flags); > if (vgadev_find(pdev) != NULL) { > -- > 2.1.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center