From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753527AbbI3PAL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Sep 2015 11:00:11 -0400
Received: from mail-la0-f44.google.com ([209.85.215.44]:36442 "EHLO
	mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751154AbbI3PAH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Sep 2015 11:00:07 -0400
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Paul Moore <paul@paul-moore.com>, Eric Paris <eparis@parisplace.org>,
        James Morris <james.l.morris@oracle.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org,
        selinux@tycho.nsa.gov, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 5/5] selinux: use sprintf return value
Organization: D03
References: <1443220459-11042-1-git-send-email-linux@rasmusvillemoes.dk>
	<1443220459-11042-6-git-send-email-linux@rasmusvillemoes.dk>
	<560AD5AF.4070400@tycho.nsa.gov>
X-Hashcash: 1:20:150930:linux-kernel@vger.kernel.org::8yGM7QSjPMoKhDJl:0000000000000000000000000000000000iaW
X-Hashcash: 1:20:150930:sds@tycho.nsa.gov::ytcXri2ZcfaidlSe:000000000000000000000000000000000000000000002gQm
X-Hashcash: 1:20:150930:paul@paul-moore.com::Y/jk0aRkVgfuwgdu:0000000000000000000000000000000000000000002ru0
X-Hashcash: 1:20:150930:linux-security-module@vger.kernel.org::iXXbM6OxFTpz9qfu:0000000000000000000000002/OX
X-Hashcash: 1:20:150930:james.l.morris@oracle.com::zdo961belZLL051Q:0000000000000000000000000000000000003u3i
X-Hashcash: 1:20:150930:serge@hallyn.com::+zghdkEaoKSDbHOq:0AU1K
X-Hashcash: 1:20:150930:selinux@tycho.nsa.gov::CAKz0dz8Qok/uoAj:0000000000000000000000000000000000000000DGrw
X-Hashcash: 1:20:150930:eparis@parisplace.org::602aXoLO96Wq382e:0000000000000000000000000000000000000000FTz1
Date: Wed, 30 Sep 2015 17:00:04 +0200
In-Reply-To: <560AD5AF.4070400@tycho.nsa.gov> (Stephen Smalley's message of
	"Tue, 29 Sep 2015 14:17:19 -0400")
Message-ID: <87zj04j6kr.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Sep 29 2015, Stephen Smalley <sds@tycho.nsa.gov> wrote:

> On 09/25/2015 06:34 PM, Rasmus Villemoes wrote:
>> sprintf returns the number of characters printed (excluding '\0'), so
>> we can use that and avoid duplicating the length computation.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Acked-by:  Stephen Smalley <sds@tycho.nsa.gov>

Thanks. I also like Joe's add-on suggestion (except I'd declare user,
role, type as const char*).

Rasmus