From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753540AbaICCO3 (ORCPT ); Tue, 2 Sep 2014 22:14:29 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:55246 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887AbaICCO1 (ORCPT ); Tue, 2 Sep 2014 22:14:27 -0400 Date: Tue, 02 Sep 2014 19:14:26 -0700 (PDT) Message-ID: <87zjeh5u2o.wl%kuninori.morimoto.gx@gmail.com> From: Kuninori Morimoto To: "Li.Xiubo@freescale.com" Cc: Jean-Francois Moine , "mark.rutland@arm.com" , "andrew@lunn.ch" , "alsa-devel@alsa-project.org" , "pawel.moll@arm.com" , "kuninori.morimoto.gx@renesas.com" , "devicetree@vger.kernel.org" , "tiwai@suse.de" , "linux-kernel@vger.kernel.org" , "ijc+devicetree@hellion.org.uk" , "lgirdwood@gmail.com" , "jsarha@ti.com" , "robh+dt@kernel.org" , "broonie@kernel.org" , "galak@codeaurora.org" Subject: Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card. In-Reply-To: <37e5ba204cb340bc9fe01b7473721a9d@BY2PR0301MB0613.namprd03.prod.outlook.com> References: <1409649969-15759-1-git-send-email-Li.Xiubo@freescale.com> <1409649969-15759-4-git-send-email-Li.Xiubo@freescale.com> <20140902124438.36da4b85@armhf> <37e5ba204cb340bc9fe01b7473721a9d@BY2PR0301MB0613.namprd03.prod.outlook.com> User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xiubo > > > /* > > > - * soc_bind_dai_link() will check cpu name > > > - * after of_node matching if dai_link has cpu_dai_name. > > > - * but, it will never match if name was created by fmt_single_name() > > > - * remove cpu_dai_name to escape name matching. > > > - * see > > > + * In soc_bind_dai_link() will check cpu name after > > > + * of_node matching if dai_link has cpu_dai_name. > > > + * but, it will never match if name was created by > > > + * fmt_single_name() remove cpu_dai_name to escape > > > + * name matching. Please see: > > > * fmt_single_name() > > > * fmt_multiple_name() > > > */ > > > > The patch done by Kuninori, setting the cpu_dai_name to NULL in all > > cases, does not work. This sequence should be replaced where is was > > previously. > > > > If so, it should be another issue here, should we send another patch for > It ? I posted patch yesterday, and Jean tested it Subject: [PATCH][RFC] ASoC: simple-card: fixup cpu_dai_name clear case Date: Tue, 02 Sep 2014 20:05:32 +0900 Best regards --- Kuninori Morimoto