From: "Bjørn Mork" <bjorn@mork.no>
To: gdt@gdt.id.au
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
Date: Wed, 27 Feb 2013 10:07:11 +0100 [thread overview]
Message-ID: <87zjyq86rk.fsf@nemi.mork.no> (raw)
In-Reply-To: <20130226.172955.926853809838377302.davem@davemloft.net> (David Miller's message of "Tue, 26 Feb 2013 17:29:55 -0500 (EST)")
David Miller <davem@davemloft.net> writes:
>> Applied, thanks Glen.
>
> Actually, I had to revert, this doesn't even compile against
> current sources:
>
> CC [M] drivers/net/usb/asix_devices.o
> drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here (not in a function)
> make[1]: *** [drivers/net/usb/asix_devices.o] Error 1
> make: *** [drivers/net/usb/asix_devices.o] Error 2
I believe this patch will make checkpatch cry
ERROR: do not use C99 // comments
as well. It would be nice if that was fixed as well before resending.
But please keep the commit message :)
Bjørn
next prev parent reply other threads:[~2013-02-27 9:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 4:17 Glen Turner
2013-02-26 4:23 ` Greg Kroah-Hartman
2013-02-26 4:45 ` David Miller
2013-02-26 5:03 ` Greg KH
2013-02-26 5:10 ` David Miller
2013-02-26 5:20 ` Greg KH
2013-02-26 21:09 ` Richard Ash
2013-02-26 22:28 ` David Miller
2013-02-26 22:29 ` David Miller
2013-02-27 9:07 ` Bjørn Mork [this message]
2013-02-27 14:32 ` [PATCHv2] " Glen Turner
2013-02-27 18:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zjyq86rk.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=gdt@gdt.id.au \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®