From: "Jürgen Groß" <jgross@suse.com>
To: Andy Lutomirski <luto@amacapital.net>, linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, x86 <x86@kernel.org>
Subject: Re: [tip: x86/urgent] x86/entry/32: Fix XEN_PV build dependency
Date: Mon, 6 Jul 2020 06:15:35 +0200 [thread overview]
Message-ID: <88031c06-ebef-8290-fa0b-695859c1a40e@suse.com> (raw)
In-Reply-To: <5B8B5845-1145-43BC-B790-B1D1A7B42B28@amacapital.net>
On 05.07.20 22:24, Andy Lutomirski wrote:
>
>
>> On Jul 5, 2020, at 12:44 PM, tip-bot2 for Ingo Molnar <tip-bot2@linutronix.de> wrote:
>>
>> The following commit has been merged into the x86/urgent branch of tip:
>>
>> Commit-ID: a4c0e91d1d65bc58f928b80ed824e10e165da22c
>> Gitweb: https://git.kernel.org/tip/a4c0e91d1d65bc58f928b80ed824e10e165da22c
>> Author: Ingo Molnar <mingo@kernel.org>
>> AuthorDate: Sun, 05 Jul 2020 21:33:11 +02:00
>> Committer: Ingo Molnar <mingo@kernel.org>
>> CommitterDate: Sun, 05 Jul 2020 21:39:23 +02:00
>>
>> x86/entry/32: Fix XEN_PV build dependency
>>
>> xenpv_exc_nmi() and xenpv_exc_debug() are only defined on 64-bit kernels,
>> but they snuck into the 32-bit build via <asm/identry.h>, causing the link
>> to fail:
>>
>> ld: arch/x86/entry/entry_32.o: in function `asm_xenpv_exc_nmi':
>> (.entry.text+0x817): undefined reference to `xenpv_exc_nmi'
>>
>> ld: arch/x86/entry/entry_32.o: in function `asm_xenpv_exc_debug':
>> (.entry.text+0x827): undefined reference to `xenpv_exc_debug'
>>
>> Only use them on 64-bit kernels.
>
> Jürgen, can you queue a revert for when PV32 goes away?
Yes, will do.
Juergen
prev parent reply other threads:[~2020-07-06 4:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 19:44 tip-bot2 for Ingo Molnar
2020-07-05 20:24 ` Andy Lutomirski
2020-07-06 4:15 ` Jürgen Groß [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88031c06-ebef-8290-fa0b-695859c1a40e@suse.com \
--to=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®