From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86B11C433F5 for ; Tue, 12 Apr 2022 03:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344243AbiDLDcA (ORCPT ); Mon, 11 Apr 2022 23:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236713AbiDLDbz (ORCPT ); Mon, 11 Apr 2022 23:31:55 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17887D76 for ; Mon, 11 Apr 2022 20:29:37 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kcrl43RHYzgY8b; Tue, 12 Apr 2022 11:27:44 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 12 Apr 2022 11:29:32 +0800 Subject: Re: [PATCH 0/4] A few cleanup and fixup patches for migration To: "ying.huang@intel.com" CC: , , , , , , , , , , , , , , , , , , Andrew Morton References: <20220409073846.22286-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <880376f0-f480-979b-261f-72cf9475474c@huawei.com> Date: Tue, 12 Apr 2022 11:29:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/4/12 10:25, ying.huang@intel.com wrote: > On Sat, 2022-04-09 at 15:38 +0800, Miaohe Lin wrote: >> Hi everyone, >> This series contains a few patches to remove unneeded lock page and >> PageMovable check, reduce the rcu lock duration. Also we fix potential >> pte_unmap on an not mapped pte. More details can be found in the >> respective changelogs. Thanks! > > It appears that you ignored my comments for the previous version. Can > you check it? I do remember [1] and I tried to make isolate_huge_page consistent with isolate_lru_page. But their return value conventions are different. isolate_huge_page return 0 when success while isolate_huge_page returns true in this case. So make them consistent would lead to many code change. I should have added this in my changelog. Thanks. [1] https://lore.kernel.org/linux-mm/8735jsgctq.fsf@yhuang6-desk2.ccr.corp.intel.com/ > > Best Regards, > Huang, Ying > >> --- >> v1: >>   rebase [1] on mainline. >> >> [1] https://lore.kernel.org/lkml/20220304093409.25829-2-linmiaohe@huawei.com/T/ >> --- >> Miaohe Lin (4): >>   mm/migration: reduce the rcu lock duration >>   mm/migration: remove unneeded lock page and PageMovable check >>   mm/migration: return errno when isolate_huge_page failed >>   mm/migration: fix potential pte_unmap on an not mapped pte >> >>  include/linux/migrate.h | 2 +- >>  include/linux/swapops.h | 4 ++-- >>  mm/filemap.c | 10 +++++----- >>  mm/hugetlb.c | 2 +- >>  mm/migrate.c | 31 +++++++++++++------------------ >>  5 files changed, 22 insertions(+), 27 deletions(-) >> > > > > . >