From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932875AbcIAKby (ORCPT ); Thu, 1 Sep 2016 06:31:54 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:30932 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932588AbcIAKbu (ORCPT ); Thu, 1 Sep 2016 06:31:50 -0400 X-AuditID: cbfec7f4-f79cb6d000001359-a9-57c803927f42 Subject: Re: [PATCH 1/6] pinctrl: dt-bindings: samsung: Update documentation with new macros To: Javier Martinez Canillas , Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim References: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com> <1472721715-2833-2-git-send-email-k.kozlowski@samsung.com> <8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com> Cc: Arnd Bergmann , Linus Walleij , Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <880fac86-0a8b-2151-c926-89281fe69be1@samsung.com> Date: Thu, 01 Sep 2016 12:31:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <8dda7bb7-fb99-3e13-be03-e21e3b18e501@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t/xy7qTmE+EG5w9JGjxd9IxdouNM9az Wsw/co7V4s3bNUwWr18YWvQ/fs1scf78BnaLKX+WM1lsenyN1eLyrjlsFjPO72OyWHr9IpNF 694j7BaH37SzWqza9YfRgd9jzbw1jB6/f01i9Ng56y67x6ZVnWwed67tYfPYvKTeY0s/UKhv yypGj8+b5AI4o7hsUlJzMstSi/TtErgyNvz5w1zQw1PxYeUk9gbGdq4uRk4OCQETiQlfLjND 2GISF+6tZ+ti5OIQEljKKPF7czsLhPOMUeLFpensIFXCAnESh+7PB6sSEVjILHFkdzM7RNUe RollN6eBZZgFmhkl5tzdzwbSwiZgLLF5+RIwm1fATmLv5d2MIDaLgKrE4U3nwWxRgQiJW6s+ MkLUCEr8mHyPBcTmFHCW2P7nIVMXIwfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoW MDKvYhRNLU0uKE5KzzXUK07MLS7NS9dLzs/dxAiJri87GBcfszrEKMDBqMTD6/DmWLgQa2JZ cWXuIUYJDmYlEV41xhPhQrwpiZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2aWpBa BJNl4uCUamBcaMAaN098Hd8U/zdKPc/W8rSxrCu71sB2Id6CoeB23eFyjzOvC8x3f9It/5vQ c3g5e3zVB+cPRU+a+UVu6D/2/982484FzlV+DXM0TwiGflgk2D3jpe6VKvZ2ff62H9939HHx V16unDO3/GGuwte9WzgPOezzf2TYHnKidNffU69Oeh0898BEiaU4I9FQi7moOBEAivvSV6oC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2016 12:29 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 09/01/2016 11:21 AM, Krzysztof Kozlowski wrote: >> Update examples in Samsung pinctrl dt-bindings with new macros coming >> from header file. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../bindings/pinctrl/samsung-pinctrl.txt | 42 +++++++++++----------- >> 1 file changed, 21 insertions(+), 21 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> index 6db16b90873a..828ef7fdd437 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> @@ -238,53 +238,53 @@ Example 1: A pin-controller node with pin groups. >> >> uart0_data: uart0-data { >> samsung,pins = "gpa0-0", "gpa0-1"; >> - samsung,pin-function = <2>; >> - samsung,pin-pud = <0>; >> - samsung,pin-drv = <0>; >> + samsung,pin-function = ; >> + samsung,pin-pud = ; >> + samsung,pin-drv = ; >> }; > > I wonder if besides updating the examples, the DT binding shouldn't also > mention include/dt-bindings/pinctrl/samsung.h and list the macros for each > possible pin configuration. Yes, of course it should. I actually added it at beginning but then checkout and I tested my sed scripts... I'll fix it in v2. Best regards, Krzysztof