From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>,
jbaron@akamai.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH 1/2] dyndbg: dont panic over bad input
Date: Mon, 21 Sep 2020 12:29:29 -0700 [thread overview]
Message-ID: <88110ffe6b08a2b403f30f4ea7463d5dad50b80b.camel@perches.com> (raw)
In-Reply-To: <20200921190433.1149521-2-jim.cromie@gmail.com>
On Mon, 2020-09-21 at 13:04 -0600, Jim Cromie wrote:
> This BUG_ON, from 2009, caught the impossible case of a word-char both
> starting and ending a string (loosely speaking). A bad (reverted)
> patch finally hit this case, but even "impossibly bad input" is no
> reason to panic the kernel. Instead pr_err and return -EINVAL.
[]
> diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
[]
> @@ -259,7 +259,10 @@ static int ddebug_tokenize(char *buf, char *words[], int maxwords)
> } else {
> for (end = buf; *end && !isspace(*end); end++)
> ;
> - BUG_ON(end == buf);
> + if (end == buf) {
> + pr_err("expected non-empty bareword");
missing newline
This message is also unintelligible.
What is a non-empty bareword?
next prev parent reply other threads:[~2020-09-21 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 19:04 [PATCH 0/2] dyndbg: 2 fixes/cleanups for 5.9 Jim Cromie
2020-09-21 19:04 ` [PATCH 1/2] dyndbg: dont panic over bad input Jim Cromie
2020-09-21 19:29 ` Joe Perches [this message]
2020-09-22 3:57 ` jim.cromie
2020-09-22 8:08 ` Petr Mladek
2020-09-22 14:23 ` jim.cromie
2020-09-27 12:29 ` Greg KH
2020-09-21 19:04 ` [PATCH 2/2] dyndbg: use keyword, arg varnames for query term pairs Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88110ffe6b08a2b403f30f4ea7463d5dad50b80b.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®