From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 749F327AC4C for ; Fri, 16 May 2025 18:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747421736; cv=none; b=ij5UlQdl6W19GPHWfgsuqJ68X6vqBZk2q3ta535Kb7lAGo+6/KPZ6sc/DZBxMf6z28wlUuq/0Oajo/9xl8f9lh8S5q3jPOOLopAsWvZoY1qWPPZGdCp6pu8gno5V0+0Bp4OweIGmaQ7DmC4kbMZSzN6JEdl4qq+k0jokxTAh9PY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747421736; c=relaxed/simple; bh=G3eptgK8Klfl0SQ0qKF2kBePOio3LIT52ROdnYjywmk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ow53ROUNRWv+mWa6PMixWPmiAHtZTTTW4+/WJTm8KyMEV2VY4mIsXx9KfzqcS8vwWfanD8KAJGD5kqrp85q2h2IBO+PQFtzKwejlULNet81S476ZV58+MoCPMzrhjPYx/yVGaaZH77xU5NqAFtfwh5z57dSDTPExD5OGWt5SlPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YzsoAMCv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YzsoAMCv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747421732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Ncy0IOMN62OZsySnUUO+DO+ffjUqHUwVWIhcHttPrHk=; b=YzsoAMCvKGDZtp00ZQ4KcdKqaiRh3Cfe4m9Wflxss5+DA1ymB/bIZohTFu89K8OFWXSxLh UA9ChMbrAh58cgJwI+/eLwvF7tkLT+rZuq9BOl9T4fBXgEmfOKWOVhqst/zhzk5F6w3d43 G3wNF3idzMl4fEcHYFu3laITxwM35CQ= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-tYGrDB20OVaYqihL7QL2Jw-1; Fri, 16 May 2025 14:55:31 -0400 X-MC-Unique: tYGrDB20OVaYqihL7QL2Jw-1 X-Mimecast-MFC-AGG-ID: tYGrDB20OVaYqihL7QL2Jw_1747421730 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43eed325461so13906905e9.3 for ; Fri, 16 May 2025 11:55:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747421730; x=1748026530; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Ncy0IOMN62OZsySnUUO+DO+ffjUqHUwVWIhcHttPrHk=; b=dXcZERPcMU5ED/k6H/JH76iGOCSuYwgLjGIXHCWX6VPCAwrswrUcraVnxff4NiemZE IXsaUtYKV9f3DbMakUd8JjaYIF9I/gceKW5yXhYzcOGI6PIea4Vykh619X8dP2v3x5/5 x08B6mJSoZgHQwG1KFdCHy4L/wARGSVYMkW1EzQwtPJCPdOE1SZ4CtWP7TT4Pix/BOFu WE4KHWaLdmm1pH+VV2D+w2ChHqFvpMS/5tR+kag+ltI7L4P5F1F2vW9EDy9wh1u/uiwa 4W88h3JlwtIs/tZK9/fYK34ZYKbWh/4i6C2PMkCRDXKEr2LwRkvn/s81PHgf/Hdwb06I phlw== X-Gm-Message-State: AOJu0YwrF/DW+9yf6gto5skNG3Aca99PY3qviSPXwxxpW0vX0jsIGI1N QN+xuko0lG9xIfiV4wcBuG5V5I38C4/zU1bl3TiEMU/QabM77f/lJUhncDoFQid0uhMQfHcr/2Z Msh1/+PVfjjBnTovS333dlL9NeYi7V2PMjLB+wZnXBbLkSZYK0iis6YHlSLsIeyUUWQ== X-Gm-Gg: ASbGncuI3YeYqvleZL/BTFAqorZc2HIdD0C5QbNEaiAqt7O2zh+0K6kz0sOCfnmjgPP 3OkTWVfNZg793En9nwwIUZFF9rpMWmdU/jOll87l3Q8g9e/Jsl8gXD/7J7ZjniHBY3qQHSZdcOT m0Hd+btQ1Ah9QDg8XkPeO2tCKkOpc4QKyeR5Xe9ytD6D9pOA5g6twa39+IzCEElrBLxtoBIxLzf LbCAKlSTh95uk36tigm6h/LYj6xfuJGBSICh3pT4lDj4HuTV2doBVS4ubClMPk0dJNe0GSUsx5k BcOzQ+vL9S9HWIese2HFDbSuzpXrq6igFGHOowIAYg== X-Received: by 2002:a05:6000:1acf:b0:3a2:25d3:3912 with SMTP id ffacd0b85a97d-3a3601d0869mr3566035f8f.57.1747421729866; Fri, 16 May 2025 11:55:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnvFvNMoXbCy664/fMYQNUZNHGmO5/8svXPk9nFJJT/F2j7rlj0r91U2NP66XBmlT+dm2IQA== X-Received: by 2002:a05:6000:1acf:b0:3a2:25d3:3912 with SMTP id ffacd0b85a97d-3a3601d0869mr3566005f8f.57.1747421729439; Fri, 16 May 2025 11:55:29 -0700 (PDT) Received: from [192.168.3.141] (p57a1ac29.dip0.t-ipconnect.de. [87.161.172.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a363d1fba6sm1606167f8f.95.2025.05.16.11.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 May 2025 11:55:29 -0700 (PDT) Message-ID: <8811fc8a-5f1a-4a1b-883b-f006da844e55@redhat.com> Date: Fri, 16 May 2025 20:55:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] s390/uv: handle folios that cannot be split while dirty To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Christian Borntraeger , Janosch Frank , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Thomas Huth , Matthew Wilcox , Zi Yan , Sebastian Mitterle References: <20250516123946.1648026-1-david@redhat.com> <20250516190755.32917d48@p-imbrenda> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250516190755.32917d48@p-imbrenda> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.05.25 19:07, Claudio Imbrenda wrote: > On Fri, 16 May 2025 14:39:43 +0200 > David Hildenbrand wrote: > >> From patch #3: >> >> " >> Currently, starting a PV VM on an iomap-based filesystem with large >> folio support, such as XFS, will not work. We'll be stuck in >> unpack_one()->gmap_make_secure(), because we can't seem to make progress >> splitting the large folio. >> >> The problem is that we require a writable PTE but a writable PTE under such >> filesystems will imply a dirty folio. >> >> So whenever we have a writable PTE, we'll have a dirty folio, and dirty >> iomap folios cannot currently get split, because >> split_folio()->split_huge_page_to_list_to_order()->filemap_release_folio() >> will fail in iomap_release_folio(). >> >> So we will not make any progress splitting such large folios. >> " >> >> Let's fix one related problem during unpack first, to then handle such >> folios by triggering writeback before immediately trying to split them >> again. >> >> This makes it work on XFS with large folios again. >> >> Long-term, we should cleanly supporting splitting such folios even >> without writeback, but that's a bit harder to implement and not a quick >> fix. > > yet another layer of duck tape > > I really dislike the current interaction between secure execution and > I/O, I hope I can get a cleaner solution as soon as possible I'll be more than happy to review such a series -- hoping we can just support large folios naturally :) > > Reviewed-by: Claudio Imbrenda > > Thanks! > David: thanks for fixing this mess! NP; I had a prototype of patch #3 for a long time. But after rebasing on top of your work I saw these weird validation errors and just couldn't find the issue. And I only saw them with patch #3 on ordinary pagecache folios, not with shmem, which severely confused. ... gave it another try today after ~1month and almost immediately spotted the issue. Some things just need time :) -- Cheers, David / dhildenb