From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 809EA3A0E8A for ; Mon, 23 Mar 2026 12:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774268283; cv=none; b=qcSI0c1qBB5sHWc6qAqcaBUIQWv8PGa4XsnhKY1yixEwyfQxejcq0K+8sUZqSQVaqZXZUEEUZ7amyTZCwdP2Z4TN01SkQN1tSSPtpOsKABOfg72+uTkXgeMD3aeBLYzBi5NJQEy6QUwMEKvhUTLiMDFU0gSM3QqKNDoXSBt+vnk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774268283; c=relaxed/simple; bh=+NIP/QEBfbHgGlgR+4OsAbfezPvxpfUc5R2/1QflK/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NloSssHoDQW31l48WOIuJ/5wuGZRdAjBAxFz5ZmJxPw3aOexUWAqc6mc7gW5lIGUNMAqLCO4PsHnzY5+RSrcXPfWTMKHQjcy8JRQF5/fW2ZdIrD/+91RNB5n7nKmgFDVHtkvh2mU43HpN6J7e7eXZ7C1+sfazTpsXU5LcMKKRd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mcUhNLib; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OiyBDgqM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mcUhNLib"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OiyBDgqM" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N7tbJN1627188 for ; Mon, 23 Mar 2026 12:17:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zQxWWwGHP3smhnCWo5d2Wy5SBQHeT3nOxa6W8LchT0Q=; b=mcUhNLibLfvjaoxl jU/IGGiDRwre5ILwv0MZ3/HlIYXKrrVoID/KgoK9De9sG//Tg3jBfKxix4c7gKFd oSG4/izB9JfiloIcPMvgkIrKb5D77PkHhcwB03k4b9cIPUvdaPNlyFtYBguzs7uo N7Rxrvms2aUsE84tmw7v21GvZRd9IPequNsNgMymXcUp5JZc7W6SDiS0hQV3ijsy 6h0gq43KsFSOc5I44of60/pzbkKD6PyIs+pZ6fOjxtl02hdIYi8Q/L6zdKzKm9Et zmVFjSTWsnPyS6nvMBxb8cDdX6vxd+Jd+U0gGVKs6drfDsbhgg/0QkuCxM0ysRh7 5g/86g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jc0wcd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 12:17:56 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b317c4041so27388251cf.1 for ; Mon, 23 Mar 2026 05:17:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774268276; x=1774873076; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zQxWWwGHP3smhnCWo5d2Wy5SBQHeT3nOxa6W8LchT0Q=; b=OiyBDgqMOHYUkvTb6kW0mwLr/Z7Tf4yUuRapITok7uI1s/IFX9hdyVCJTzJZvm7eqQ r6hcDWA9+92DXf+AgWBrx9pumtnFDsSWXKOkU8ceJHhItyyoMc+Oou3rZ0ou4w25XiQ2 8n26xl2t9tjlxNFsykVarrH+qtNYMwqOVPNKQzxmmW9OiiP/q2LUx22L8WFNYSoeKjK4 +0G2MArsQEjdlZvrHmxfh9h9sVG7jNBLmU6fL3FG6jti4qBLHFzr4hBB+jisjdkwf3an H4Fk7Wamx0STn0DwFW2VykGEC1sAEyy9Ld2v1QGbh2z8GchJfCO8ZeH7XlYB1qPR3i2V 2Eog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774268276; x=1774873076; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zQxWWwGHP3smhnCWo5d2Wy5SBQHeT3nOxa6W8LchT0Q=; b=VuWtah7X8JVBV7fLzq666uQifZ0JqwK/aQO6HGwHpMABj1ke+pXPXGz4/Uq8YmS3Pn lBlBOm02zJRzLZ4grEh6jHjhj6e74OfMId/toikdAYX/gh+EYHTZomVjgXEzReVBT7tl vIZzpRkZiWRHhB5kd2siuyvBaxYgkJWfnr6qgJM1W6KNLNq9ltTPHbDUsy+qEiL6i7uW xWXXfSB+UQdNH50i2wiAL+tt/bRgJSyiOIM/JDZZ9jbSbtK5JeE4ES51YJW3oJuE9qmz K19dW6LRAJjHvLrynoiql82lwMOna8of3QQItzG9oKJNeGPq5lSJ1FOaehFS4fA6JSA2 6QVQ== X-Forwarded-Encrypted: i=1; AJvYcCWiKusEV46ArI9dWFvLNOBowVqvfND4ceqOqvXnr3LrUCAxEuiUMJMUQYN4H0L6rLK1GHtJFtZoyHovgiE=@vger.kernel.org X-Gm-Message-State: AOJu0YwlQ0sN2zQIm9kZxt1iK2RGQZNhsoGDWgM9EaiU/rr505DjxW3G /Qojv1zsnprqVzAmyt1xUHiWHG2tMCn0SbOcVwbiJSMZVZhPsVrJ7vA7rMLrrSfKY+v5z2fmv1l Sik7L++xDO7dnficBoluX/Pk8tA5Kdg8gMgT35FsQ6uXy1CvNc7p5ZP67dEAOm6sm6Yc= X-Gm-Gg: ATEYQzzGatZZI84v6lO9z2XsN4PQMwr4OydjA4xHPgKnp7FkUyIQWgoBOD3t4H4esc6 0RjHmqWpsriUdH1RLFpRQCsliT+Ss7YRkskrLIlT2xfqtyneVWKZ2PbzNYMeQS+sYoyHa8tx8Cu VrurKAm0vflu7/AHs+O0H6JpqQjmbNACDgQe5k1SXbU5dTkpeTakvBSgk7Z7yK0RWcNhJbNf3zs XuFbhGPxxfl20ww/XUuUN2fecTCMOcYaMAkKkrnltZAOqLxpQM5oQBoMHU1XkDN2WhdtWW3EYNN 0oZnFZZ5It1lT9iZvS4rlcvD/UrtSs4NkpN6JYr/cXVYBQgkERhCjjpAsGZ2uV6gPFlAGrifEeG ZPFU2aRenT7w0BGeGcNhe6+8yq1jhO9PoyfyWQkMjFCejbsRjsP0qJU+3gm9RoXNKvP1xjGeipc 62+7o= X-Received: by 2002:ac8:7f0f:0:b0:509:1924:3f60 with SMTP id d75a77b69052e-50b3753fc76mr135242271cf.9.1774268275736; Mon, 23 Mar 2026 05:17:55 -0700 (PDT) X-Received: by 2002:ac8:7f0f:0:b0:509:1924:3f60 with SMTP id d75a77b69052e-50b3753fc76mr135241951cf.9.1774268275248; Mon, 23 Mar 2026 05:17:55 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9832f43ae8sm489737566b.6.2026.03.23.05.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 05:17:54 -0700 (PDT) Message-ID: <881975ea-cc16-4b26-9672-731c146a1ba8@oss.qualcomm.com> Date: Mon, 23 Mar 2026 13:17:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 3/3] arm64: dts: qcom: Add Samsung Galaxy Book4 Edge DTS/DTSI To: Maxim Storetvedt , andersson@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: marcus@nazgul.ch, marijn.suijten@somainline.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, abel.vesa@linaro.org, abel.vesa@oss.qualcomm.com, johan@kernel.org, konradybcio@kernel.org, kirill@korins.ky References: <20260322160317.424797-1-mstoretv@cern.ch> <20260322160317.424797-4-mstoretv@cern.ch> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260322160317.424797-4-mstoretv@cern.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=fKc0HJae c=1 sm=1 tr=0 ts=69c12f74 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=jXqzSn9no9U_C95JTX0A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: F7wlAOpFC71C7GK2BiIyw0kQfCDa1POu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA5NSBTYWx0ZWRfX/wxLXM9T6VGX sPG/u6/7JZqi0W3p4DsA2AqIxkanEL05hhQC7a7ekCgq1N1X/LFqVblJQG4wu3xyhoK4t7CbapH WonMEjdaPlWWEoJY8Wr1GRpnl3qt1HbAbkoM9hH9wXg21WuGRxQJctDtrBWBWdqRlqHboaK2P8z 2MiM8GJd3u7e71Fq4eIzHkSL0NE3lC3/CMSRh2utEH1gO35MjWtL3PugKmGHhFWGDguIFzNRGm9 YVCmz5Dimj/skdmd80iNnQCz5/29nTXsFS1sa8hqe2Ymjc7POD2rpjHUbOwb9Z3+XNIRVKmBXKq RhZIy2Vobwn+Fn6kO8VbyDvcMuzg4dTTHLANng/g3GdwfgKU1G9Y+KLuOSVKcaeubPlJQinIUrW VejHJ5TMBjECQeEze8WXAmSaVhyN6kpLmu0/ZSB2vaagi8V/3eukQXuIrnUvbYGTdCaTHAYJbZV KgfXKqpNivL4fSfTcMg== X-Proofpoint-ORIG-GUID: F7wlAOpFC71C7GK2BiIyw0kQfCDa1POu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230095 On 3/22/26 5:03 PM, Maxim Storetvedt wrote: > Adds devicetrees for the 14-inch and 16-inch SKUs of the Samsung Galaxy Book4 Edge. > > These use a common dtsi derived from nodes that were able to work on Linux > from the initial Galaxy Book4 Edge DTS by Marcus: > > Link: https://lore.kernel.org/all/p3mhtj2rp6y2ezuwpd2gu7dwx5cbckfu4s4pazcudi4j2wogtr@4yecb2bkeyms/ > > combined with the ongoing patch for the Honor Magicbook Art 14, and its downstream by > Valentin Manea, which shares device similarities: [...] > + model = "Samsung Galaxy Book4 Edge"; > + compatible = "samsung,galaxy-book4-edge", "qcom,x1e80100"; > + chassis-type = "laptop"; > + > + aliases { > + serial0 = &uart21; > + serial1 = &uart14; > + }; > + > + wcd938x: audio-codec { > + compatible = "qcom,wcd9385-codec"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&wcd_default>; property-n property-names in this order, file-wide, please [...] > + pmic-glink { > + compatible = "qcom,x1e80100-pmic-glink", > + "qcom,pmic-glink"; > + #address-cells = <1>; > + #size-cells = <0>; > + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>, > + <&tlmm 123 GPIO_ACTIVE_HIGH>, > + <&tlmm 125 GPIO_ACTIVE_HIGH>; You provide 3 orientation-gpios but there's only two ports [...] > + sound { > + compatible = "qcom,x1e80100-sndcard"; > + model = "X1E80100-CRD"; This should reflect the actual machine > + audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT", > + "TweeterLeft IN", "WSA WSA_SPK2 OUT", > + "WooferRight IN", "WSA2 WSA_SPK2 OUT", > + "TweeterRight IN", "WSA2 WSA_SPK2 OUT", > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "MIC BIAS3", > + "VA DMIC1", "MIC BIAS3", > + "VA DMIC2", "MIC BIAS1", > + "VA DMIC3", "MIC BIAS1", > + "VA DMIC0", "VA MIC BIAS3", > + "VA DMIC1", "VA MIC BIAS3", > + "VA DMIC2", "VA MIC BIAS1", > + "VA DMIC3", "VA MIC BIAS1", See: b49e37de8e70 ("arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies") > + "TX SWR_INPUT1", "ADC2_OUTPUT"; > + > + wcd-playback-dai-link { > + link-name = "WCD Playback"; > + > + cpu { > + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>; > + }; > + > + codec { 'co'dec < 'cp'u, please reorder [...] > +&i2c8 { > + clock-frequency = <400000>; > + > + status = "okay"; > + > + touchscreen@5d { > + compatible = "hid-over-i2c"; > + reg = <0x5d>; > + > + hid-descr-addr = <0x1>; > + interrupts-extended = <&tlmm 34 IRQ_TYPE_LEVEL_LOW>; > + > + vdd-supply = <&vreg_misc_3p3>; > + /* Lower power supply is not enoug to work. */ > + // vddl-supply = <&vreg_l15b_1p8>; How should we interpret that? [...] > +/* usb1 covers left side typec ports */ > + > +/* back(towards the display) typec port */ You already have these comments near the type-c connector definitions at the top of the file [...] > +/* DP-HDMI bridge connected here? */ > +&usb_1_ss2_qmpphy { > + vdda-phy-supply = <&vreg_l2j_1p2>; > + vdda-pll-supply = <&vreg_l2d_0p9>; > + > + qcom,combo-initial-mode = "dp"; This was used in some previous version of the QMPPHY-DP-only patchset, see e.g. x1p42100-lenovo-thinkbook-16.dts and align with that to get it working again [...] > +&panel { > + compatible = "samsung,atna40cu07", "samsung,atna33xc20"; I think it'd make sense to move the compatible from 'common' to the 16in DTS then too > + enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>; this matches the common definition > + power-supply = <&vreg_edp_3p3>; ditto > + no-hpd; really?? Konrad