From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E7F2C68A for ; Thu, 25 Jan 2024 10:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706179656; cv=none; b=Sc+NSXQ5ajE65buuRI+xd6gv1oPErTqrviCSneYotgHqerX0p9l4gYHqlPiN3LoFbx6/OMDMkk94HZfEaDaIaLTuZN4oRMVcmQLDGgcgUmK7yan3+WiGcy9gUHjNhxTcaXuHvO1BzQTU0a1dyPV0xKGmPiaTtf4rZLb4lVWmzrs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706179656; c=relaxed/simple; bh=qJIg0nvxYKMBKmg9Lhg6zXZeiFWgXvu5JEPYYVLhYxQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EY1x31+cjjG8M/haNiYoSynojQyh0wZHf8hFZAg5Ymp9jyz/6RcjOhrrGGy2wQTDIakOSxMu6eWhljKYRArdqbpsfarAT6tAEOguuR8KTvLYcc48AJwXHKBvrgt1dyvvokKRI+MZRtAICY84Ao8hbv59bMhVYKt6DEfYCae2dZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bgLBp3qM; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bgLBp3qM" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-559f92bf7b6so1246187a12.0 for ; Thu, 25 Jan 2024 02:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706179653; x=1706784453; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qUFAOyfRItBatkmptoSKoqwFpaIM1BAzd3p4SNYrB6U=; b=bgLBp3qMDn/NKigV0lqh9fP3GrnOCCLK+I9v+MA76a6JDT9pvrLtKvwHUPECtvDwWO MDYqA4cyO9rk6mV5xngQZ2n3LEO4IIjuH+Pz0vWeOMUZmeEQariM2AKU/TY+Tt5KqFsp cjiHe9VGCpm9UngKeQr+J2RcJ1USYxETB79iZ55u9HweXcmWl8nrlAmyn7VDGIk8prrC JBF5n7ZtoGNvUhndyrkvsnFixm6s27PzkEiQqSsBgldQI86x6xxVVSxzSHm6pP6pYcDo n12QcSzCkOOuBOlLmCa4vDJ4vmqQsL4Y1+SHPjMlIEoF6hlc8EQc/ZNGC3UaAyuQuGOK eSXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706179653; x=1706784453; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qUFAOyfRItBatkmptoSKoqwFpaIM1BAzd3p4SNYrB6U=; b=oGCUfyd4f70YxEJ+NLhboD/bAdSd2Z6iTjWpq26S54mHLiDPhTVurNbkqUNsRVvXRz ZN5gjh6nSfTILXCIsqZn4SpYuR4D8dNIu+iOuPsgDOCbPcWHiFbX+k8Nxzan3m6zyj3W GAUzJcVayELz22az+GHuNNf8s5N/vMNVwnZS+mtxsg+bbZ4XvCtAFBkQowmXQEtq36rc d6lfh/pDaXPsBcLbhFYqF4t9X5dUZfG8BuaQd5XWOSaFkbXZKn+hZm17M8ON1VSxSV5O TiHWfWhEPivH8HzzC27AA5aL0e5o/dpWp8kbJV5+cqmc/1eV6USD85uuLUqoNZGYjOXV Yi1A== X-Gm-Message-State: AOJu0Yx8she1FghVJFM5bh5pZxMKNMZP0zgUfPEsmMa0q6qw2KB8LBpN dy6YhOZx8yDhRX/PkbLXOvIteu9Bge89DIlP1FoN1Q8kXLAqb+uBu8Odn4VmJkA= X-Google-Smtp-Source: AGHT+IGGj4vSRzfftcEVG6rM3xZqRkxzdcFtwoOvKC5XBbaTa6FBjakxOvxN8g0kvbtWCTFNOwVYgw== X-Received: by 2002:aa7:c158:0:b0:55d:1615:4bd7 with SMTP id r24-20020aa7c158000000b0055d16154bd7mr9510edp.6.1706179653252; Thu, 25 Jan 2024 02:47:33 -0800 (PST) Received: from [172.30.205.155] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id ez15-20020a056402450f00b0055a82fe01cdsm6389475edb.67.2024.01.25.02.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 02:47:32 -0800 (PST) Message-ID: <8819b406-34a4-48ba-8d69-25cb4cbcf3e1@linaro.org> Date: Thu, 25 Jan 2024 11:47:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240124164505.293202-1-krzysztof.kozlowski@linaro.org> <20240124164505.293202-2-krzysztof.kozlowski@linaro.org> <3f03ebc4-c67a-40cb-8863-d9c800af54fa@linaro.org> From: Konrad Dybcio In-Reply-To: <3f03ebc4-c67a-40cb-8863-d9c800af54fa@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/25/24 11:43, Krzysztof Kozlowski wrote: > On 25/01/2024 10:59, Konrad Dybcio wrote: >> >> >> On 1/24/24 17:45, Krzysztof Kozlowski wrote: >>> WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact >>> it is offset by one. Correct it to fix recording via analogue >>> microphones. >>> >>> The change is based on QRD8550 and should be correct here as well, but >>> was not tested on MTP8550. >> >> Would this not be codec-and-not-board-specific, anyway? > > Yes, indeed, it should be. Should we move this to the driver and drop the then-uselesss dt property? Konrad