Re: [PATCH -next v2] scsi: efct: don't use GFP_KERNEL under spin lock

[James Smart <jsmart2021@gmail.com>]

On 1/10/2022 5:24 PM, Yang Yingliang wrote:
> GFP_KERNEL/GFP_DMA can't be used under a spin lock, according the
> comment of els_ios_lock, it's used to protect els ios list, so we
> can move down the spin lock to avoid using this flag under the lock.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 8f406ef72859 ("scsi: elx: libefc: Extended link Service I/O handling")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
>    move up unlock to just protect list_add_tail()
> ---
>   drivers/scsi/elx/libefc/efc_els.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 

Looks fine.

Reviewed-by: James Smart <jsmart2021@gmail.com>

-- james