From: bot+bpf-ci@kernel.org
To: cui.tao@linux.dev,tj@kernel.org,josef@toxicopanda.com,axboe@kernel.dk,ast@kernel.org,alexei.starovoitov@gmail.com
Cc: cgroups@vger.kernel.org,linux-block@vger.kernel.org,linux-kernel@vger.kernel.org,bpf@vger.kernel.org,andrii@kernel.org,eddyz87@gmail.com,daniel@iogearbox.net,linux-kselftest@vger.kernel.org,cui.tao@linux.dev,cuitao@kylinos.cn,ameryhung@gmail.com,ast@kernel.org,andrii@kernel.org,daniel@iogearbox.net,martin.lau@kernel.org,eddyz87@gmail.com,yonghong.song@linux.dev,mason@kernel.org,ihor.solodrai@linux.dev
Subject: Re: [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
Date: Wed, 18 Nov 2026 13:49:00 +0000 (UTC) [thread overview]
Message-ID: <8823762c289ef6a65710cf359f0bd7e930fb53b08c98852d2bd759a9f437fcc3@mail.kernel.org> (raw)
In-Reply-To: <20261118131029.797007-3-cui.tao@linux.dev>
[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]
> blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
TL;DR: The new iocost_ioc_tick tracepoint comment describes vrate as relative
to VTIME_PER_SEC, but it is likely vtime per usec (VTIME_PER_USEC is 100%), so
users following it would get values 10^6 too small.
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
[ ... ]
> +/*
> + * Periodic per-device summary, emitted once per period before the vrate
> [ ... ]
> + * vrate is the current vrate in vtime units, where one IO time second
> + * is VTIME_PER_SEC (2^37) vtime and cost.vrate in io.stat reports the
> + * same value as a percentage of that base.
Is this description of vrate accurate? The field is filled from
ioc->vtime_base_rate, which is vtime per wall-clock microsecond:
__entry->vrate = ioc->vtime_base_rate;
and io.stat computes cost.vrate as a percentage of VTIME_PER_USEC, not
VTIME_PER_SEC:
unsigned vp10k = DIV64_U64_ROUND_CLOSEST(
ioc->vtime_base_rate * 10000,
VTIME_PER_USEC);
ioc_refresh_vrate() does the same with
div64_u64(ioc->vtime_base_rate * 100, VTIME_PER_USEC).
Someone following the comment would compute vrate * 100 / 2^37 and get a
value 10^6 too small, since the nominal 100% value is 137438 (2^37 / 10^6).
The commit message points readers to this header for the exact meaning of
the fields. Could the comment say that vrate is in vtime per wall-clock
usec, with VTIME_PER_USEC being 100% as reported by cost.vrate in io.stat?
[ ... ]
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44312765238
next prev parent reply other threads:[~2026-11-18 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:10 [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model Tao Cui
2026-11-18 13:10 ` [RFC PATCH v14 1/4] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-11-18 13:10 ` [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary Tao Cui
2026-11-18 13:49 ` bot+bpf-ci [this message]
2026-11-18 13:10 ` [RFC PATCH v14 3/4] selftests/bpf: add iocost cost model test Tao Cui
2026-11-18 13:49 ` bot+bpf-ci
2026-11-18 13:10 ` [RFC PATCH v14 4/4] docs: cgroup-v2: document the iocost BPF cost model attachment Tao Cui
2026-11-18 13:17 ` [RFC PATCH v14 0/4] blk-iocost: BPF struct_ops cost model Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8823762c289ef6a65710cf359f0bd7e930fb53b08c98852d2bd759a9f437fcc3@mail.kernel.org \
--to=bot+bpf-ci@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®