From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754183AbdKNLtn (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 06:49:43 -0500
Received: from mout.web.de ([212.227.15.3]:49312 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752510AbdKNLte (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 06:49:34 -0500
Subject: Re: [PATCH 0/7] ALSA: Fine-tuning for several function
 implementations
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: alsa-devel@alsa-project.org, Clemens Ladisch <clemens@ladisch.de>,
        Jaroslav Kysela <perex@perex.cz>,
        Martin Koegler <martin.koegler@chello.at>,
        Takashi Iwai <tiwai@suse.com>,
        Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <f2404d64-27c8-4afa-b893-fc72601c0136@users.sourceforge.net>
Message-ID: <882a7baa-7c23-c60c-076f-73daa1753531@users.sourceforge.net>
Date: Tue, 14 Nov 2017 12:48:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <f2404d64-27c8-4afa-b893-fc72601c0136@users.sourceforge.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:MtF2U2BYebV1whlIITvbeSS96mxbGihCF2XQxSxBOX5h2d3Sff9
 5Dyl4ALOyAJbOrlVLJ+qe998WbhBMpxN529lqc/gDWC+np6dg2h/HXFL1JFMfx8JoIFYUKC
 0TiKd65wtzdaCO42z1R5fs8C8JPi9sMVHnjjsjwc5YtBaz4oSeVkxzeAPUoye5kuHmRVclv
 L44qVR8Wei2xn6t5OQVsg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:rjbuHDx7ZVg=:To4d2jsZDysIZWeEnljMnx
 6h54UG74BwYhBmHXMUwc9sO6iGi9DTuXvF5mBQ67BT9QkUkRTyNg7GcXRxFOja5rYEuF4eOHe
 3/n5R4SitTbs/fubvQb7kxQKIid1mcTOfGemsfbD0ae5vYJENwAVP4MLf7zUnpmQzHwJIQlyO
 AdFfIJWbLRwfbZ9EmGU+Inx3sQR7TGxAH2Hgcr/TJAi538PIEbgBffK5w8lkToAsrvyLv5k97
 HIUHnBPWMjb+fQnsZNynOBrFiZPzGAW3h9CU2p/91XTsFlSAqPG1zTJvLIdYo1ZJbwyyRSBCS
 K0hlmYPeqxEuUWnC/d6fmu5lXzG9kctyNpaDExCD/R20p3M6DTS8GFoTeXHa1MvLOxMoY5WS+
 W2O6DvF4p6xzKzV6VlSOwBOd+rfsq5TupOe4E4e+GeNs4p4kqo7JwaZWhNoO3OOzAMljy4/LF
 Myp/14emDejrD51zwb83iL3lhvyWX0eWo9D7xAu5g2isDD8+m18Y0TZFqDVZBuSNTW1Bmv2JX
 fWlJ5fAN8Qxu6X4yIZFnrTgVA3BCZPmAhHmNRHhw+VyV30x2PIlofAJMywzdI7NQRYQEfxUTt
 UxzV1WrP9z1P2kVTtPNw0UiL/4gwEEQwK8NFryVhbwX3vesXiHqix1YsdyZMJ7EveU5p/axv7
 vO5+7VQXfZilN/K1ubzjJg8Tpo30c5CDptftDOqQbxF14tLMnH3WIYAExVl7L6i2YFJyrGzLp
 GgPhgEMXvl7O4qJsUTY3t4N1SAIPbxd/4WolUptTIMWtcM594kTcw8n6pAgtIlDO3Vi7zda6+
 bCc6mroMsbgC42winG6Q3OTmaQRwW8QEOoVXTJBTM1sHJJ7x3E=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Date: Tue, 24 Jan 2017 11:02:34 +0100
> 
> Some update suggestions were taken into account
> from static source code analysis.
> 
> Markus Elfring (7):
>   seq: Delete unnecessary checks in snd_seq_ioctl_query_subs()
>   seq: Delete unnecessary checks in snd_seq_ioctl_get_subscription()
>   seq: Delete unnecessary checks in snd_seq_ioctl_unsubscribe_port()
>   seq: Delete unnecessary checks in snd_seq_ioctl_subscribe_port()
>   seq: Adjust 16 function calls together with a variable assignment
>   dmasound_core: Move two assignments for the variable "ret" in state_open()
>   dmasound_core: Adjust six function calls together with a variable assignment
> 
>  sound/core/seq/seq_clientmgr.c     | 163 ++++++++++++++++++++-----------------
>  sound/oss/dmasound/dmasound_core.c |  33 +++++---
>  2 files changed, 109 insertions(+), 87 deletions(-)

Are these update suggestions worth for another look?
https://lkml.org/lkml/2017/1/24/292

Regards,
Markus