From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DF4C433E8 for ; Tue, 28 Jul 2020 10:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7E6B120786 for ; Tue, 28 Jul 2020 10:44:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728845AbgG1KoB (ORCPT ); Tue, 28 Jul 2020 06:44:01 -0400 Received: from www62.your-server.de ([213.133.104.62]:47752 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbgG1KoA (ORCPT ); Tue, 28 Jul 2020 06:44:00 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1k0N5P-0003Hy-B5; Tue, 28 Jul 2020 12:43:55 +0200 Received: from [178.196.57.75] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0N5P-000Whq-0j; Tue, 28 Jul 2020 12:43:55 +0200 Subject: Re: [PATCH][next] bpf: fix swapped arguments in calls to check_buffer_access To: Yonghong Song , Colin King , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Andrii Nakryiko , John Fastabend , KP Singh , netdev@vger.kernel.org, bpf@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200727175411.155179-1-colin.king@canonical.com> From: Daniel Borkmann Message-ID: <882cd37d-0af2-3412-6bd7-73aa466df23c@iogearbox.net> Date: Tue, 28 Jul 2020 12:43:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.3/25886/Mon Jul 27 16:48:28 2020) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/27/20 11:39 PM, Yonghong Song wrote: > On 7/27/20 10:54 AM, Colin King wrote: >> From: Colin Ian King >> >> There are a couple of arguments of the boolean flag zero_size_allowed >> and the char pointer buf_info when calling to function check_buffer_access >> that are swapped by mistake. Fix these by swapping them to correct >> the argument ordering. >> >> Addresses-Coverity: ("Array compared to 0") >> Fixes: afbf21dce668 ("bpf: Support readonly/readwrite buffers in verifier") >> Signed-off-by: Colin Ian King > > Thanks for the fix! > Acked-by: Yonghong Song Sigh, thanks for the fix Colin, applied! Yonghong, could you follow-up with BPF selftest test cases that exercise these paths? Thx