From: Damien Le Moal <damien.lemoal@wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stefan Haberland <sth@linux.vnet.ibm.com>,
axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, hoeppner@linux.vnet.ibm.com,
sebott@linux.vnet.ibm.com
Subject: Re: [RFC] block: check partition alignment
Date: Thu, 15 Dec 2016 17:56:00 +0900 [thread overview]
Message-ID: <88308b2d-de52-b97a-2001-96da7e9f5d1f@wdc.com> (raw)
In-Reply-To: <20161215084553.GA19716@infradead.org>
On 12/15/16 17:45, Christoph Hellwig wrote:
> On Thu, Dec 15, 2016 at 10:33:47AM +0900, Damien Le Moal wrote:
>> For a regular block device, I agree. But in Stephan case, I think that
>> the check really needs to be against the physical block size, with the
>> added condition that the bdev is a DASD device (similarly to the zone
>> alignment check for zoned block devices).
>
> Then they need to expose a chunk_size. physical block size is defined
> as not having a meaning for the kernel.
Or create the block device with the logical block size set to the
physical sector size. Which would be even more simple and in fact
correct in this case since only physically aligned accesses make sense
for DASD.
--
Damien Le Moal, Ph.D.
Sr. Manager, System Software Research Group,
Western Digital Corporation
Damien.LeMoal@wdc.com
(+81) 0466-98-3593 (ext. 513593)
1 kirihara-cho, Fujisawa,
Kanagawa, 252-0888 Japan
www.wdc.com, www.hgst.com
next prev parent reply other threads:[~2016-12-15 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 16:47 Stefan Haberland
2016-12-14 17:07 ` Christoph Hellwig
2016-12-15 1:33 ` Damien Le Moal
2016-12-15 8:45 ` Christoph Hellwig
2016-12-15 8:56 ` Damien Le Moal [this message]
2016-12-19 16:15 ` Stefan Haberland
2016-12-19 16:15 ` [v2] " Stefan Haberland
2016-12-19 16:18 ` Christoph Hellwig
2016-12-15 0:29 ` [RFC] " Damien Le Moal
2016-12-15 0:55 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88308b2d-de52-b97a-2001-96da7e9f5d1f@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=hoeppner@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebott@linux.vnet.ibm.com \
--cc=sth@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®