From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C68802BE644 for ; Tue, 18 Nov 2025 11:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763465012; cv=none; b=VDuaIMgeZtMmDHTbosaIfyzGLPC00iBeMpxSGxg/l2Ed0+PMYhA0B9CtRxWGR0B7KsEZ6Z4IsG6g9Zx8KuvNPwrGKNFdZajxWkgk403TR+W5OC4fJ4j0Pu/ltWzoMAdUiKgks39F4pc1HEW26xS5Xux8nE4CkGhppqiacaKBw/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763465012; c=relaxed/simple; bh=jRxq3ewCSJc+jxAhUG4ibJ4ufu+h4co9k72tV0osL+8=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=mW7Am5mfTbwqYipKBU1Qo/j53Eu016I+eh7boW6S5ugGsGgkkokhIsgkYSjGsBZ1FVitCiwOODcf40Ybc7ZEMvDZcM5sp15/1HRSzMC2h/Ym7PsZXUaJbE58XTzHl5pY+vEsjj0OA5fGAdMbjsSI4IrYW/H7UM8+r7MiNuWo9NE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y+E44rwK; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y+E44rwK" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-297d4a56f97so59434395ad.1 for ; Tue, 18 Nov 2025 03:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763465010; x=1764069810; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=WovrDOD/v+hm0oJf+TFW/PTjUsqQxA+rdneFLIgQGzE=; b=Y+E44rwKz0An2+QpmvwWvvjosIF/+PRuIXSPawEme7b17+cYs2hLds2ksL4Jc42Xni h0OIg+ofEwAWWypG1GXmAXsnLshtVoysxt3Xbbpt9vSi2Ar64vyiXFvE27cw8FHk5xzJ nhUdGckZYJ8EfkXOhnnvFuCEjISs2jGoGptZicxVAoieL8yltrsbJSmCy0km7L0tTheE nW2n6UJQz/9h72TRisxbdq8uBMwVOqiUhxxOh16RyGrgD0zRBg9TgYIJS9fmQIzG/S5W /w6wwrvoNzr+JPV0jiC5QcmvdCRfiNBmGTeHy40JZck/bvv7qecd17aZjya8CoUoPK3b Fg8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763465010; x=1764069810; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WovrDOD/v+hm0oJf+TFW/PTjUsqQxA+rdneFLIgQGzE=; b=huafk1YsonyEHHTyc4jv1mDXbc8dhZkmxrsEjEEdIAKsBjKUDXNDKkOh3HM5vQnjy0 zp5QVe4CJiU8eRvV7QRVhkDCc2MXlNmm74/1X4SEtsfO4AJ8SviWL3nQCSaZ6FQrYlYG F8y4DuZwuu9GWKAKFgjhvA0otOCx/7RSlugxmHlicVytDOOm2EJOcimddOJslb4lzcZS URfOimLxl6YyNDV1B6x/wUQ7VRSoLpiDSRQ0C0oTcVGiWbGRZWs5Ifsg27zlk5IB3h51 ifrlU7xrQ/c1zpw5uVoJ4pRwz1JS1QoMH7PsTmcLs/zKmKch7xSaopgn8AthqUQ58EuB v+PQ== X-Forwarded-Encrypted: i=1; AJvYcCW8P6ZUlIQLdJuYnYod71JK962+hhHMCknyTYYtQd7o7wFspvF5gh4dBXha2j7VzJlrXF5ca03ndA0Dvq0=@vger.kernel.org X-Gm-Message-State: AOJu0YzUoy1zdSFfs40VH2BFvevS4rmAnL41Vvw3Gdx+R2d1CRdM+aTR eJnIL2PMb21lydxkLg8dORoeY18SlFF4pVC/DFvcRJabn3Q+fEFBlsjokldmNA== X-Gm-Gg: ASbGncs4FnZc3N6yWZsw0U72Hjtcfu1R//K/3A34wAW53OuUmqjX+9ladltKKEtB2sJ RboPgDERnoY8cw2XB/ZJdhCDT9b5Z5FoL1tE1BKn1G6KP//2DKAdW7ypf+M1Dly8Fm1ICZj+xl5 GjqieIUQspPaTuZHwB0GXh/cGNts4E5+lbnGpSIkXluqVp9q73ao2AbZlk668qz+jv0eOBtWUp1 pZOnGARQlcS8DZu82kGOn6jnAKJ88AqgS/sMh6xFgQuGxDyLr5v1iGwtTl5XHztRUHUBJg5Wb7t HD4Vgr5mG3MgeBLU9pZEUF3V2p/bfqfpwzRgQ/B382XFL6Dh6WCz/Gr/CfGgl671BAGsddxuim+ lagZNSLvSQEyuxsqy0MjRXJO6MCRUp9MxyKRlmnx8jIzoKLkxBja6LjYVkAkPNGPQsuHxnHDOV+ AiyWuitUh/wsqGKzYhI3wtzk9+lSxIy+biGTFo6320lhQHT89UcYff9CU= X-Google-Smtp-Source: AGHT+IFJgF6/yZx2++MVekhAyAbtGKs0OVIuCERy7L50xiNNEXZ+X3spfJOI+YZiBtB+TWbnBofhMQ== X-Received: by 2002:a17:903:2948:b0:295:9db1:ff41 with SMTP id d9443c01a7336-2986a6be5b3mr131180765ad.21.1763465009910; Tue, 18 Nov 2025 03:23:29 -0800 (PST) Received: from ?IPV6:2405:201:31:d869:12a7:9863:8e31:b180? ([2405:201:31:d869:12a7:9863:8e31:b180]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2b1055sm172014445ad.59.2025.11.18.03.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 03:23:29 -0800 (PST) Message-ID: <8831475d-0eeb-4107-ad87-c9c8736c219c@gmail.com> Date: Tue, 18 Nov 2025 16:53:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: syzbot+87be6809ed9bf6d718e3@syzkaller.appspotmail.com Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <69155df4.a70a0220.3124cb.0016.GAE@google.com> Subject: Re: [syzbot] [cifs?] memory leak in smb3_fs_context_fullpath Content-Language: en-US From: shaurya In-Reply-To: <69155df4.a70a0220.3124cb.0016.GAE@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index 0f894d09157b..975f1fa153fd 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -1834,6 +1834,12 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,      ctx->password = NULL;      kfree_sensitive(ctx->password2);      ctx->password2 = NULL; +    kfree(ctx->source); +    ctx->source = NULL; +    if (fc) { +        kfree(fc->source); +        fc->source = NULL; +    }      return -EINVAL;  } -- 2.34.1