From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E0CC433EF for ; Mon, 20 Sep 2021 12:53:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F47360F6B for ; Mon, 20 Sep 2021 12:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238887AbhITMzM (ORCPT ); Mon, 20 Sep 2021 08:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238869AbhITMzJ (ORCPT ); Mon, 20 Sep 2021 08:55:09 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B05F8C061762 for ; Mon, 20 Sep 2021 05:53:42 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id c22so60959418edn.12 for ; Mon, 20 Sep 2021 05:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EtHYpsyKq+obMQJvRNPJVQMXf1iuDZUh4kTqBS/uYM8=; b=nNONN3xb1H+5+JXdtkASL0DQ3moevZl1ILUbtQ81z5bCCIUzOVY1VDOtQdsjxPXU1R ng04/g42xmWszmb8jK0nJm+YZSMkQiLf0uF/aNBai0uwjR55S5Sm/SdHxFuGnmzafS/1 fbF9aZhVgBcHUneh1LdNMMK+P0ykoeVEC7kj3IHEE/2JlxRdihRfBSGa7qTVjrP9ma4J Y05ke1tqbhE3wCIyqtAvLMBHdp1bJ1jfJVdxN6a7DwxgWth8jbiHExKq5bDTUeatQHHa 6BK6l/6LXLR+XDmLD0hhQpSf9LtKNar7Fd2ul7SPE+GNjEU3dvTZBTSJntlSDr26Z1ug hUDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EtHYpsyKq+obMQJvRNPJVQMXf1iuDZUh4kTqBS/uYM8=; b=LUpyyNCpNqqpz8MMelU39yJt7KXGaHx8Us5WylejYbPUOEVC6VAj3oJu6rgstwIC63 +D83sCpC44rcidRi13v5n8FrRyPUV2jKdjAUcS6awVtnd2uUeMSyqGOBfL5bt/Z0S6Ri NZIN1Nie7jhy4QEBC6lG4x8yWbuLxDfftqWtyDPEcPVuFrzYdAlYESSi86KLOPKzOZbz JP5R+bIBcYucJ8bqHN1tPGXZR0XZA/MNV0sFZJeCYvuHvDos3IEwGTVX2/v60uS0jd/Q TvvYm9J94RnECfMpynezMhFVnYr5x+QIKZzPqGoY/N837vzFEoiO+NGGXdN+GmzTmlC2 baog== X-Gm-Message-State: AOAM5304OO8eKTAE/CHNvEvtUP+dOMKmylrWS/ZheDVr/2vwAyR7/GOz FGRNY7CDS175zKN5c78wjlx4XQ== X-Google-Smtp-Source: ABdhPJwrX21ltRM664L1DNZZYOaApHbWpHu5Z7CzKNWhhq27r9m7D1bzPoJw1xgYV5gmNFAzAsA7gQ== X-Received: by 2002:a17:906:dbf2:: with SMTP id yd18mr14559102ejb.536.1632142421107; Mon, 20 Sep 2021 05:53:41 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id bm1sm6171601ejb.38.2021.09.20.05.53.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 05:53:40 -0700 (PDT) Subject: Re: [PATCH] misc: fastrpc: Update number of max fastrpc sessions To: Greg KH , Jeya R Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, fastrpc.upstream@qti.qualcomm.com References: <1632123274-32054-1-git-send-email-jeyr@codeaurora.org> From: Srinivas Kandagatla Message-ID: <88370a7c-9e28-ae1b-2f48-bc38a8cff78f@linaro.org> Date: Mon, 20 Sep 2021 13:53:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2021 08:51, Greg KH wrote: > On Mon, Sep 20, 2021 at 01:04:34PM +0530, Jeya R wrote: >> For latest chipsets, upto 13 fastrpc sessions can be >> supported. This includes 12 compute sessions and 1 cpz >> session. Not updating this might result to out of bounds >> memory access issues if more than 9 context bank nodes >> are added to the DT file. >> >> Signed-off-by: Jeya R >> --- >> drivers/misc/fastrpc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index beda610..bd7811e 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -24,7 +24,7 @@ >> #define SDSP_DOMAIN_ID (2) >> #define CDSP_DOMAIN_ID (3) >> #define FASTRPC_DEV_MAX 4 /* adsp, mdsp, slpi, cdsp*/ >> -#define FASTRPC_MAX_SESSIONS 9 /*8 compute, 1 cpz*/ >> +#define FASTRPC_MAX_SESSIONS 13 /*12 compute, 1 cpz*/ >> #define FASTRPC_ALIGN 128 >> #define FASTRPC_MAX_FDLIST 16 >> #define FASTRPC_MAX_CRCLIST 64 >> -- >> 2.7.4 >> > > What happens if you run this on "older" chipsets? This change should not have any implications on the older chips, as the existing compute context bank device tree entries will not exceed 9. > > And is this an issue now, or can this wait to 5.16-rc1? We could wait take in 5.16-rc1, as its an enhancement to allow more compute context banks. --srini > > thanks, > > greg k-h >