From: David Laight <David.Laight@ACULAB.COM>
To: 'Vasily Gorbik' <gor@linux.ibm.com>,
Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>,
Miroslav Benes <mbenes@suse.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/2] compiler.h: Avoid using inline asm operand modifiers
Date: Wed, 10 Nov 2021 10:39:35 +0000 [thread overview]
Message-ID: <88372012a2374a8fa6e34a709e03b767@AcuMS.aculab.com> (raw)
In-Reply-To: <your-ad-here.call-01636386038-ext-6578@work.hours>
From: Vasily Gorbik
> Sent: 08 November 2021 15:41
>
> On Fri, Nov 05, 2021 at 09:54:18AM -0700, Josh Poimboeuf wrote:
> > On Wed, May 19, 2021 at 03:03:08PM +0200, Vasily Gorbik wrote:
> > > The expansion of annotate_reachable/annotate_unreachable on s390 will
> > > result in a compiler error if the __COUNTER__ value is high enough.
...
> > I wonder if we could go back to the original approach of providing
> > __COUNTER__ as an input to the asm, but then mask it to < 128.
...
> > * The __COUNTER__ based labels are a hack to make each instance of the macros
> > * unique, to convince GCC not to merge duplicate inline asm statements.
I've used asm comments get the same effect.
Annoyingly there isn't a standard comment delimiter.
I think you can just use a .equ (or .set) directive (to assign a value)
rather than putting a value into a 'to be discarded' section.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-11-10 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 13:03 [PATCH 0/2] objtool annotations: " Vasily Gorbik
2021-05-19 13:03 ` [PATCH 1/2] compiler.h: " Vasily Gorbik
2021-11-05 16:54 ` Josh Poimboeuf
2021-11-08 15:40 ` Vasily Gorbik
2021-11-08 16:50 ` Josh Poimboeuf
2021-11-10 10:39 ` David Laight [this message]
2021-05-19 13:03 ` [PATCH 2/2] instrumentation.h: " Vasily Gorbik
2021-05-19 20:52 ` [PATCH 0/2] objtool annotations: " Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88372012a2374a8fa6e34a709e03b767@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=bp@suse.de \
--cc=gor@linux.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®